From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
davem@davemloft.net, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v6 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch
Date: Fri, 21 Apr 2017 09:10:23 -0700 [thread overview]
Message-ID: <1492791023.6453.29.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <6b26ef20-972f-24bf-22bf-8462606ce16d@mojatatu.com>
On Fri, 2017-04-21 at 11:40 -0400, Jamal Hadi Salim wrote:
> On 17-04-21 11:20 AM, Eric Dumazet wrote:
> > On Fri, 2017-04-21 at 11:12 -0400, Jamal Hadi Salim wrote:
> >> On 17-04-21 09:12 AM, Jiri Pirko wrote:
> >>> Fri, Apr 21, 2017 at 12:55:31PM CEST, jhs@mojatatu.com wrote:
> >>>> From: Jamal Hadi Salim <jhs@mojatatu.com>
> >>
>
> >> Jiri, there is a balance between extensibility and performance.
> >> It is senseless to use a TLV just so i can set a 0/1(true/false).
> >
> > You assume that the (user space) did sensible things.
> >
>
> If it didnt it is a bug. Seriously.
If the application runs fine on linux-4.0, it is our _duty_ [1] to allow
it to run on linux-4.12.
Particularly if we have very easy ways to do so.
Like using new attributes instead of trying to 'reuse' some padding.
Pretending the old compiler or old applications were buggy is absolutely
irrelevant. That is not the point.
[1] Ask Linus Torvalds about that if you really need to get a final
arbitration.
next prev parent reply other threads:[~2017-04-21 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 10:55 [PATCH net-next v6 0/3] net sched actions: improve dump performance Jamal Hadi Salim
2017-04-21 10:55 ` [PATCH net-next v6 1/3] net sched actions: User proper root attribute table for actions Jamal Hadi Salim
2017-04-21 13:08 ` Jiri Pirko
2017-04-21 14:50 ` Jamal Hadi Salim
2017-04-21 10:55 ` [PATCH net-next v6 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-04-21 13:12 ` Jiri Pirko
2017-04-21 15:12 ` Jamal Hadi Salim
2017-04-21 15:20 ` Eric Dumazet
2017-04-21 15:40 ` Jamal Hadi Salim
2017-04-21 16:07 ` David Miller
2017-04-21 16:10 ` Eric Dumazet [this message]
2017-04-21 10:55 ` [PATCH net-next v6 3/3] net sched actions: add time filter for action dumping Jamal Hadi Salim
2017-04-21 13:13 ` Jiri Pirko
2017-04-21 15:13 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492791023.6453.29.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox