netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: dsa@cumulusnetworks.com, Vladislav Yasevich <vyasevic@redhat.com>
Subject: [PATCH v3 net-next 0/2] rtnetlink: Updates to rtnetlink_event()
Date: Fri, 21 Apr 2017 13:31:19 -0400	[thread overview]
Message-ID: <1492795881-11914-1-git-send-email-vyasevic@redhat.com> (raw)

This is a version 3 series came out of the conversation that started
as a result my first attempt to add netdevice event info to netlink messages.

First, let's clean-up the duplicate notifications for NETDEV_CHANGNAME
event.  We get a message from the event handler as well as a result of
do_setlink().  The two messages are identical, so remove the event.

Second, update the original patch to add IFLA_EVENT attribute
to the link message to only support currently white-listed events.
Like before, this is just an attribute that gets added to the rtnetlink
message only when the messaged was generated as a result of a netdev event.
In my case, this is necessary since I want to trap NETDEV_NOTIFY_PEERS
event (also possibly NETDEV_RESEND_IGMP event) and perform certain actions
in user space.  This is not possible since the messages generated as
a result of netdev events do not usually contain any changed data.  They
are just notifications.  This patch exposes this notification type to
userspace.

I will also update my patch to iproute that will show this data
through 'ip monitor'. 


V3: Rebased.  Cleaned-up duplicate event.

V2: Added missed events (from David Ahern)

Vladislav Yasevich (2):
  rtnetlink: Convert rtnetlink_event to white list
  rtnl: Add support for netdev event to link messages

 include/linux/rtnetlink.h    |   3 +-
 include/uapi/linux/if_link.h |  21 ++++++++
 net/core/dev.c               |   2 +-
 net/core/rtnetlink.c         | 121 +++++++++++++++++++++++++++++++++++--------
 4 files changed, 123 insertions(+), 24 deletions(-)

-- 
2.7.4


Vladislav Yasevich (2):
  rtnetlink: Disable notification for NETDEV_NAMECHANGE event
  rtnl: Add support for netdev event to link messages

 include/linux/rtnetlink.h    |  3 ++-
 include/uapi/linux/if_link.h | 11 ++++++++
 net/core/dev.c               |  2 +-
 net/core/rtnetlink.c         | 63 +++++++++++++++++++++++++++++++++++++-------
 4 files changed, 67 insertions(+), 12 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-04-21 18:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 17:31 Vladislav Yasevich [this message]
2017-04-21 17:31 ` [PATCH net-next 1/2] rtnetlink: Disable notification for NETDEV_NAMECHANGE event Vladislav Yasevich
2017-04-21 18:08   ` David Ahern
2017-04-27 19:26     ` Vlad Yasevich
2017-04-21 17:31 ` [PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages Vladislav Yasevich
2017-04-24  1:07   ` David Ahern
2017-04-24 15:14     ` Roopa Prabhu
2017-04-27 19:51       ` Vlad Yasevich
2017-04-28  0:11         ` Roopa Prabhu
2017-04-27 19:43     ` Vlad Yasevich
2017-04-27 19:59       ` David Ahern
2017-04-28 16:38         ` Jiri Pirko
2017-05-01 13:35           ` Vlad Yasevich
2017-05-02 21:57             ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492795881-11914-1-git-send-email-vyasevic@redhat.com \
    --to=vyasevich@gmail.com \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).