From: <Joe.Ghalam@dell.com>
To: <herbert@gondor.apana.org.au>
Cc: <davem@davemloft.net>, <Clifford.Wichmann@dell.com>,
<netdev@vger.kernel.org>
Subject: Re: macvlan: Fix device ref leak when purging bc_queue
Date: Mon, 24 Apr 2017 15:01:24 +0000 [thread overview]
Message-ID: <1493046084156.78287@Dell.com> (raw)
In-Reply-To: <20170424075606.GA19926@gondor.apana.org.au>
> The only thing that can stop macvlan_process_broadcast from getting
> called is macvlan_port_destroy. Nothing else can stop the work
> queue, unless of course the work queue mechanism itself is broken.
> So if you're sure macvlan_port_destroy is never even called in
> your case, then you'll need to start debugging the kernel work
> queue mechanism to see why macvlan_process_broadcast is not getting
> called.
I will get your changes reloaded and re-tested without any other debug tools. Hopefully, we'll see success. I will let you know if I see any issues.
Btw, is your fix committed already? if not, do you know when and where it would be committed?
Thanks,
Joe
next prev parent reply other threads:[~2017-04-24 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1492618528011.11322@Dell.com>
2017-04-20 12:55 ` macvlan: Fix device ref leak when purging bc_queue Herbert Xu
2017-04-20 16:09 ` Joe.Ghalam
2017-04-21 4:40 ` Herbert Xu
2017-04-21 14:40 ` Joe.Ghalam
2017-04-21 15:02 ` David Miller
2017-04-21 19:23 ` Mahesh Bandewar (महेश बंडेवार)
2017-04-21 20:37 ` Joe.Ghalam
2017-04-24 7:56 ` Herbert Xu
2017-04-24 15:01 ` Joe.Ghalam [this message]
2017-04-24 15:10 ` David Miller
2017-04-24 15:30 ` Joe.Ghalam
2017-04-25 14:42 ` David Miller
2017-04-25 15:19 ` Joe.Ghalam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493046084156.78287@Dell.com \
--to=joe.ghalam@dell.com \
--cc=Clifford.Wichmann@dell.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).