Netdev List
 help / color / mirror / Atom feed
From: kys@exchange.microsoft.com
To: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
	leann.ogasawara@canonical.comi, marcelo.cerri@canonical.com,
	sthemmin@microsoft.com
Cc: Alex Ng <alexng@messages.microsoft.com>,
	Michael Gissing <mg@faulpeltz.net>
Subject: [PATCH 1/6] Tools: hv: vss: Thaw the filesystem and continue if freeze call has timed out
Date: Sun, 30 Apr 2017 16:21:14 -0700	[thread overview]
Message-ID: <1493594479-25329-1-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1493594420-25214-1-git-send-email-kys@exchange.microsoft.com>

From: Alex Ng <alexng@messages.microsoft.com>

If a FREEZE operation takes too long, the driver may time out and move on
to another  operation. The daemon is unaware of this and attempts to
notify the driver that the FREEZE succeeded. This results in an error from
the driver and the daemon leaves the filesystem in frozen state.

Fix this by thawing the filesystem and continuing.

Signed-off-by: Michael Gissing <mg@faulpeltz.net>
Signed-off-by: Alex Ng <alexng@messages.microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 tools/hv/hv_vss_daemon.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index e082980..7ba5419 100644
--- a/tools/hv/hv_vss_daemon.c
+++ b/tools/hv/hv_vss_daemon.c
@@ -261,7 +261,9 @@ int main(int argc, char *argv[])
 		if (len != sizeof(struct hv_vss_msg)) {
 			syslog(LOG_ERR, "write failed; error: %d %s", errno,
 			       strerror(errno));
-			exit(EXIT_FAILURE);
+
+			if (op == VSS_OP_FREEZE)
+				vss_operate(VSS_OP_THAW);
 		}
 	}
 
-- 
1.7.1

  reply	other threads:[~2017-04-30 23:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30 23:20 [PATCH 0/6] Drivers: hv: Miscellaneous fixes kys
2017-04-30 23:21 ` kys [this message]
2017-04-30 23:21 ` [PATCH 2/6] tools: hv: properly handle long paths kys
2017-04-30 23:21 ` [PATCH 3/6] Drivers: hv: vmbus: Fix error code returned by vmbus_post_msg() kys
2017-04-30 23:21 ` [PATCH 4/6] Drivers: hv: util: Make hv_poll_channel() a little more efficient kys
2017-04-30 23:21 ` [PATCH 5/6] Drivers: hv: vmbus: Fix rescind handling kys
2017-04-30 23:21 ` [PATCH 6/6] HV: properly delay KVP packets when negotiation is in progress kys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493594479-25329-1-git-send-email-kys@exchange.microsoft.com \
    --to=kys@exchange.microsoft.com \
    --cc=alexng@messages.microsoft.com \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=devel@linuxdriverproject.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=leann.ogasawara@canonical.comi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=mg@faulpeltz.net \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox