From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-intel-i40e] question about assignment overwrite
Date: Wed, 17 May 2017 22:49:11 -0700 [thread overview]
Message-ID: <1495086551.46489.1.camel@intel.com> (raw)
In-Reply-To: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com>
[-- Attachment #1: Type: text/plain, Size: 2862 bytes --]
On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote:
> While looking into Coverity ID 1408956 I ran into the following
> piece
> of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807:
>
> 8807 if (pf->hw.mac.type == I40E_MAC_X722) {
> 8808 pf->flags |= I40E_FLAG_RSS_AQ_CAPABLE
> 8809 | I40E_FLAG_128_QP_RSS_CAPABLE
> 8810 | I40E_FLAG_HW_ATR_EVICT_CAPABLE
> 8811 | I40E_FLAG_OUTER_UDP_CSUM_CAPABLE
> 8812 | I40E_FLAG_WB_ON_ITR_CAPABLE
> 8813 |
> I40E_FLAG_MULTIPLE_TCP_UDP_RSS_PCTYPE
> 8814 | I40E_FLAG_NO_PCI_LINK_CHECK
> 8815 | I40E_FLAG_USE_SET_LLDP_MIB
> 8816 | I40E_FLAG_GENEVE_OFFLOAD_CAPABLE
> 8817 | I40E_FLAG_PTP_L4_CAPABLE
> 8818 | I40E_FLAG_WOL_MC_MAGIC_PKT_WAKE;
> 8819 } else if ((pf->hw.aq.api_maj_ver > 1) ||
> 8820 ((pf->hw.aq.api_maj_ver == 1) &&
> 8821 (pf->hw.aq.api_min_ver > 4))) {
> 8822 /* Supported in FW API version higher than 1.4 */
> 8823 pf->flags |= I40E_FLAG_GENEVE_OFFLOAD_CAPABLE;
> 8824 pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE;
> 8825 } else {
> 8826 pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE;
> 8827 }
>
> The issue here is that the assignment at line 8823 is overwritten
> by
> the code at line 8824.
>
> I'm suspicious that line 8824 should be remove and a patch like the
> following can be applied:
>
> index d5c9c9e..48ffa73 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -8821,7 +8821,6 @@ static int i40e_sw_init(struct i40e_pf *pf)
> (pf->hw.aq.api_min_ver > 4))) {
> /* Supported in FW API version higher than 1.4 */
> pf->flags |= I40E_FLAG_GENEVE_OFFLOAD_CAPABLE;
> - pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE;
> } else {
> pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE;
> }
>
> What do you think?
This issue is already fixed in my dev-queue branch on my next-queue
tree.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-18 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 20:48 [net-intel-i40e] question about assignment overwrite Gustavo A. R. Silva
2017-05-18 5:49 ` Jeff Kirsher [this message]
2017-05-18 17:44 ` Gustavo A. R. Silva
2017-06-07 19:55 ` Mauro Rodrigues
2017-06-07 20:34 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495086551.46489.1.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=garsilva@embeddedor.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).