From: Oliver Neukum <oneukum@suse.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] cdc-ether: divorce initialisation with a filter reset and a generic method
Date: Thu, 18 May 2017 12:36:34 +0200 [thread overview]
Message-ID: <1495103794.6672.5.camel@suse.com> (raw)
In-Reply-To: <8737c2eat4.fsf@miraculix.mork.no>
Am Donnerstag, den 18.05.2017, 12:09 +0200 schrieb Bjørn Mork:
> Oliver Neukum <oneukum@suse.com> writes:
>
> >
> > @@ -417,7 +434,7 @@ int usbnet_cdc_bind(struct usbnet *dev, struct usb_interface *intf)
> > BUILD_BUG_ON((sizeof(((struct usbnet *)0)->data)
> > < sizeof(struct cdc_state)));
> >
> > - status = usbnet_generic_cdc_bind(dev, intf);
> > + status = usbnet_ether_cdc_bind(dev, intf);
> > if (status < 0)
> > return status;
> >
> > @@ -472,7 +489,6 @@ static void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb)
> >
> > if (urb->actual_length < sizeof(*event))
> > return;
> > -
> > event = urb->transfer_buffer;
> >
> > if (event->bNotificationType != USB_CDC_NOTIFY_NETWORK_CONNECTION) {
> > @@ -493,7 +509,7 @@ static void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb)
> > static const struct driver_info cdc_info = {
> > .description = "CDC Ethernet Device",
> > .flags = FLAG_ETHER | FLAG_POINTTOPOINT,
> > - .bind = usbnet_cdc_bind,
> > + .bind = usbnet_ether_cdc_bind,
> > .unbind = usbnet_cdc_unbind,
> > .status = usbnet_cdc_status,
> > .set_rx_mode = usbnet_cdc_update_filter,
>
>
> I didn't quite get this. You change the call in usbnet_cdc_bind() from
> usbnet_generic_cdc_bind() to usbnet_ether_cdc_bind(), which I believe is
> fine. But then you update the .bind hook to point to usbnet_ether_cdc_bind.
> Why? The only effect I can see is that usbnet_get_ethernet_addr() is
> skipped. That can't be correct?
You are right. I am an idiot. I wanted to target RNDIS and missed totally.
Thanks.
Dave please trash the patch.
Regards
Oliver
prev parent reply other threads:[~2017-05-18 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 8:23 [PATCH] cdc-ether: divorce initialisation with a filter reset and a generic method Oliver Neukum
2017-05-18 10:09 ` Bjørn Mork
2017-05-18 10:36 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495103794.6672.5.camel@suse.com \
--to=oneukum@suse.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).