netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: Vladislav Yasevich <vyasevic@redhat.com>,
	Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Subject: [PATCH net 0/3] vlan: Offload fixes for Q-in-Q vlans
Date: Thu, 18 May 2017 09:31:02 -0400	[thread overview]
Message-ID: <1495114265-23368-1-git-send-email-vyasevic@redhat.com> (raw)

Since the following commit:

commit 8cb65d00086bfba22bac87ff18b751432fc74003
Author: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date:   Fri Mar 27 14:31:12 2015 +0900

    net: Move check for multiple vlans to drivers

offloads were broken in Q-in-Q vlans. The biggest problem was
that tcp checksum offload was enabled and used for all hardware,
while most of the supported HW (mostly old HW and some newer ones)
don't support it.  As a result, tcp connections could not be
established when using Q-in-Q vlans.

This short series corrects this by disabling checksum offload
support on packets sent through Q-in-Q vlans.  It is up to individual
drivers to enable it properly through ndo_features_check if they
have some support for Q-in-Q vlans.


Vladislav Yasevich (3):
  vlan: Fix Q-in-Q vlan support.
  be2net: Fix offload features for Q-in-Q packets
  virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

 drivers/net/ethernet/emulex/benet/be_main.c | 4 +++-
 drivers/net/virtio_net.c                    | 1 +
 include/linux/if_vlan.h                     | 1 -
 3 files changed, 4 insertions(+), 2 deletions(-)

CC: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
-- 
2.7.4

             reply	other threads:[~2017-05-18 13:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 13:31 Vladislav Yasevich [this message]
2017-05-18 13:31 ` [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan Vladislav Yasevich
2017-05-19  1:04   ` Toshiaki Makita
2017-05-19  2:13   ` Toshiaki Makita
2017-05-19  7:09     ` Vlad Yasevich
2017-05-19  8:16       ` Toshiaki Makita
2017-05-19  9:53         ` Vlad Yasevich
2017-05-19 13:31           ` Toshiaki Makita
2017-05-22 23:59   ` David Miller
2017-05-23 12:59     ` Vlad Yasevich
2017-05-23 16:29     ` Alexander Duyck
2017-05-18 13:31 ` [PATCH net 2/3] be2net: Fix offload features for Q-in-Q packets Vladislav Yasevich
2017-05-18 13:31 ` [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans Vladislav Yasevich
2017-05-18 15:06   ` Michael S. Tsirkin
2017-05-19 14:18   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495114265-23368-1-git-send-email-vyasevic@redhat.com \
    --to=vyasevich@gmail.com \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).