From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, dsahern@gmail.com
Cc: cugyly@163.com, netdev@vger.kernel.org, Linyu.Yuan@alcatel-sbell.com.cn
Subject: Re: [PATCH net-next v5] net: ipv6: fix code style error and warning of ndisc.c
Date: Sun, 21 May 2017 14:14:38 -0700 [thread overview]
Message-ID: <1495401278.2093.12.camel@perches.com> (raw)
In-Reply-To: <20170521.125404.420857788471820007.davem@davemloft.net>
On Sun, 2017-05-21 at 12:54 -0400, David Miller wrote:
> From: David Ahern <dsahern@gmail.com> Date: Sun, 21 May 2017 10:17:47 -0600
> > On 5/21/17 10:05 AM, Joe Perches wrote:
> >> But really, why bother?
> >>
> >> Just because checkpatch bleats some message doesn't
> >> mean it _has_ to be fixed.
> >>
> >> Please strive to make the code more readable and
> >> intelligible for _humans_. Compilers don't care.
> >
> > +1
> >
> > broad cleanups like this make 'git blame' harder to use to find root causes.
I don't have any issue with broad cleanups and I think
the git blame argument is overblown.
If and when broad cleanups are done, it's best if there
is some other concurrent desire to improve logic, reduce
object code size, and/or other code refactoring other
than mere whitespace changes.
prev parent reply other threads:[~2017-05-21 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 0:55 [PATCH net-next v5] net: ipv6: fix code style error and warning of ndisc.c yuan linyu
2017-05-21 16:05 ` Joe Perches
2017-05-21 16:17 ` David Ahern
2017-05-21 16:54 ` David Miller
2017-05-21 21:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495401278.2093.12.camel@perches.com \
--to=joe@perches.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).