From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Date: Mon, 22 May 2017 06:13:35 -0700 Message-ID: <1495458815.2093.18.camel@perches.com> References: <1495452830.2093.14.camel@perches.com> <72ff21ba-f774-b3d5-23b4-e70095cedbef@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko To: Jan Kiszka , Giuseppe Cavallaro , Alexandre Torgue , David Miller Return-path: Received: from smtprelay0198.hostedemail.com ([216.40.44.198]:36342 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751881AbdEVNNl (ORCPT ); Mon, 22 May 2017 09:13:41 -0400 In-Reply-To: <72ff21ba-f774-b3d5-23b4-e70095cedbef@siemens.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2017-05-22 at 14:49 +0200, Jan Kiszka wrote: > On 2017-05-22 13:33, Joe Perches wrote: > > On Mon, 2017-05-22 at 13:12 +0200, Jan Kiszka wrote: > > > Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. > > > > [] > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > > > > [] > > > @@ -31,65 +31,78 @@ > > > > [] > > > +static const struct stmmac_pci_dmi_data iot2040_stmmac_dmi_data[] = { > > > { > > > - .name = "GalileoGen2", > > > .func = 6, > > > .phy_addr = 1, > > > }, > > > { > > > - .name = "SIMATIC IOT2000", > > > - .asset_tag = "6ES7647-0AA00-0YA2", > > > - .func = 6, > > > + .func = 7, > > > > Why change this from 6 to 7? > > > > The diff is confusing here: If you look at the outcome, we now have > galileo_stmmac_dmi_data with function 6 only (also used for the > IOT2020), and iot2040_stmmac_dmi_data with both function 6 and 7 (both > MACs are wired up). Right. Apologies for noise.