From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Sander Eikelenboom <linux@eikelenboom.it>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, netdev@vger.kernel.org
Subject: Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi
Date: Mon, 22 May 2017 23:04:55 +0200 [thread overview]
Message-ID: <1495487095.26008.7.camel@sipsolutions.net> (raw)
In-Reply-To: <532c257e-52a0-18c1-1afe-04d37c28e072@broadcom.com> (sfid-20170522_230239_411441_5084F34F)
Hi Arend,
Sorry, I forgot that the original message wasn't Cc'ed to the wireless
list, only netdev.
> +++ b/net/wireless/scan.c
> @@ -322,9 +322,7 @@ static void cfg80211_del_sched_scan_req(struct
> cfg80211_regi
> {
> struct cfg80211_sched_scan_request *pos;
>
> - ASSERT_RTNL();
> -
> - list_for_each_entry(pos, &rdev->sched_scan_req_list, list) {
> + list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list,
> list) {
[snip]
This looks fine, but perhaps in the above we should have some kind of
locking assertion, e.g.
WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
johannes
next prev parent reply other threads:[~2017-05-22 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 10:36 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi Sander Eikelenboom
[not found] ` <a54f3f4f-2365-2154-ad18-82e4cd572aac-6SM94LqRVpn6gRhOQ7JHfg@public.gmane.org>
2017-05-22 10:57 ` Johannes Berg
2017-05-22 12:09 ` Arend van Spriel
[not found] ` <764a929c-ce8a-c859-a49e-2f20cb05ae44-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-05-22 21:02 ` Arend Van Spriel
2017-05-22 21:04 ` Johannes Berg [this message]
2017-05-23 7:19 ` Arend Van Spriel
2017-05-23 7:22 ` Johannes Berg
[not found] ` <1495524153.2464.2.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-05-23 7:24 ` Arend Van Spriel
2017-05-23 17:51 ` Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495487095.26008.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).