netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: alexander.duyck@gmail.com, makita.toshiaki@lab.ntt.co.jp,
	Vladislav Yasevich <vyasevic@redhat.com>
Subject: [PATCH V2 net 0/3] Fix checksum issues with Q-in-Q vlans
Date: Tue, 23 May 2017 12:53:09 -0400	[thread overview]
Message-ID: <1495558392-1238-1-git-send-email-vyasevic@redhat.com> (raw)

TCP checksum appear broken on a lot of devices that
advertise NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM.  This problem
becomes very visible/reproducable since the series
commit afb0bc972b526 ("Merge branch 'stacked_vlan_tso'").

In particular, the issue appeared consistently on bnx2 and be2net
drivers (not all drivers were tested).

This short series corrects this by disabling checksum offload
support on packets sent through Q-in-Q vlans if the underlying HW only
enables IP specific checksum features.  We currently 'assume' that
any drivers setting NETIF_F_HW_CSUM can correclty pass checksum offsets
to HW.  It is up to individual drivers to enable it properly through
ndo_features_check if they have some support for Q-in-Q vlans.

Additionally, be2net driver was fixed to make the proper call.

While looking at the drivers, it was also found that virtio-net ended
up disabling accelerations, which is unnecessary.  

V2: Instead of disabling checksuming for all devices, only devices using
    NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM are now affected by this change.
    For drivers using NETIF_F_HW_CSUM, we will continue to use checksum
    offloading.  If any drivers are found to be broken, they would need
    be fixed individually.

Vladislav Yasevich (3):
  vlan: Fix tcp checksum offloads in Q-in-Q vlans
  be2net: Fix offload features for Q-in-Q packets
  virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

 drivers/net/ethernet/emulex/benet/be_main.c |  4 +++-
 drivers/net/virtio_net.c                    |  1 +
 include/linux/if_vlan.h                     | 10 ++++++++--
 3 files changed, 12 insertions(+), 3 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-05-23 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 16:53 Vladislav Yasevich [this message]
2017-05-23 16:53 ` [PATCH V2 net 1/3] vlan: Fix tcp checksum offloads in Q-in-Q vlans Vladislav Yasevich
2017-05-23 16:53 ` [PATCH V2 net 2/3] be2net: Fix offload features for Q-in-Q packets Vladislav Yasevich
2017-05-23 16:53 ` [PATCH V2 net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans Vladislav Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495558392-1238-1-git-send-email-vyasevic@redhat.com \
    --to=vyasevich@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).