From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: alexander.duyck@gmail.com, makita.toshiaki@lab.ntt.co.jp,
Vladislav Yasevich <vyasevic@redhat.com>
Subject: [PATCH V2 net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans
Date: Tue, 23 May 2017 12:53:12 -0400 [thread overview]
Message-ID: <1495558392-1238-4-git-send-email-vyasevic@redhat.com> (raw)
In-Reply-To: <1495558392-1238-1-git-send-email-vyasevic@redhat.com>
Since virtio does not provide it's own ndo_features_check handler,
TSO, and now checksum offload, are disabled for stacked vlans.
Re-enable the support and let the host take care of it. This
restores/improves Guest-to-Guest performance over Q-in-Q vlans.
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
---
drivers/net/virtio_net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 665627c..ead7a58 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2020,6 +2020,7 @@ static const struct net_device_ops virtnet_netdev = {
.ndo_poll_controller = virtnet_netpoll,
#endif
.ndo_xdp = virtnet_xdp,
+ .ndo_features_check = passthru_features_check,
};
static void virtnet_config_changed_work(struct work_struct *work)
--
2.7.4
prev parent reply other threads:[~2017-05-23 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 16:53 [PATCH V2 net 0/3] Fix checksum issues with Q-in-Q vlans Vladislav Yasevich
2017-05-23 16:53 ` [PATCH V2 net 1/3] vlan: Fix tcp checksum offloads in " Vladislav Yasevich
2017-05-23 16:53 ` [PATCH V2 net 2/3] be2net: Fix offload features for Q-in-Q packets Vladislav Yasevich
2017-05-23 16:53 ` Vladislav Yasevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495558392-1238-4-git-send-email-vyasevic@redhat.com \
--to=vyasevich@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).