From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
hayeswang <hayeswang@realtek.com>,
netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v2 net-next 1/2] Documentation: sysfs-class-net-statistics: Clarify rx_bytes and tx_bytes
Date: Tue, 23 May 2017 23:10:57 +0200 [thread overview]
Message-ID: <1495573858-32346-2-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1495573858-32346-1-git-send-email-andrew@lunn.ch>
Document what is expected for the rx_bytes and tx_bytes statistics in
/sys/class/net/<device>/statistics. The FCS should be included in the
statistics. However, since this has been unclear until now, it is
expected a number of drivers don't. But maybe with time they will.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
Documentation/ABI/testing/sysfs-class-net-statistics | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-class-net-statistics b/Documentation/ABI/testing/sysfs-class-net-statistics
index 397118de7b5e..a487cbb79458 100644
--- a/Documentation/ABI/testing/sysfs-class-net-statistics
+++ b/Documentation/ABI/testing/sysfs-class-net-statistics
@@ -21,7 +21,8 @@ Contact: netdev@vger.kernel.org
Description:
Indicates the number of bytes received by this network device.
See the network driver for the exact meaning of when this
- value is incremented.
+ value is incremented. However, for an Ethernet frame, it should
+ include the Ethernet header, data, and frame check sum.
What: /sys/class/<iface>/statistics/rx_compressed
Date: April 2005
@@ -125,7 +126,8 @@ Description:
device. See the network driver for the exact meaning of this
value, in particular whether this accounts for all successfully
transmitted packets or all packets that have been queued for
- transmission.
+ transmission. For an Ethernet frame, it should include the
+ Ethernet header, data, and frame check sum.
What: /sys/class/<iface>/statistics/tx_carrier_errors
Date: April 2005
--
2.11.0
next prev parent reply other threads:[~2017-05-23 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 21:10 [PATCH v2 net-next 0/2] Start making stats consistent Andrew Lunn
2017-05-23 21:10 ` Andrew Lunn [this message]
2017-05-25 15:10 ` [PATCH v2 net-next 1/2] Documentation: sysfs-class-net-statistics: Clarify rx_bytes and tx_bytes Stephen Hemminger
2017-05-25 16:43 ` David Miller
2017-05-23 21:10 ` [PATCH v2 net-next 2/2] net: usb: r8152: Fix rx_bytes/tx_bytes to include FCS Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495573858-32346-2-git-send-email-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).