[PATCH 0/2] Document and use eeprom-length property

[PATCH 0/2] Document and use eeprom-length property

[Andrew Lunn]

The mv88e6xxx switch driver allows the size of the attached EEPROM to
be described in DT. This property is missing from the binding
documentation. Add it. And make use of it on the ZII Devel B board.

David, Shawn, please could you talk amongs yourself to decide who
takes what.

Andrew Lunn (2):
  net: dsa: mv88e6xxx: Add eeprom-length to binding
  ARM: VF610: ZII devel b: Add switch eeprom-length properties

 Documentation/devicetree/bindings/net/dsa/marvell.txt | 4 ++++
 arch/arm/boot/dts/vf610-zii-dev-rev-b.dts             | 2 ++
 2 files changed, 6 insertions(+)

-- 
2.11.0

[PATCH 1/2] net: dsa: mv88e6xxx: Add eeprom-length to binding

[Andrew Lunn]

The binding documentation for the mv88e6xxx switch is missing the
eeprom-length property, which has been implemented since May 2016,
commit f8cd8753def0 ("dsa: mv88e6xxx: Handle eeprom-length property")

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 Documentation/devicetree/bindings/net/dsa/marvell.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
index 7ef9dbb08957..1d4d0f49c9d0 100644
--- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
+++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
@@ -26,6 +26,10 @@ Optional properties:
 - interrupt-controller	: Indicates the switch is itself an interrupt
 			  controller. This is used for the PHY interrupts.
 #interrupt-cells = <2>	: Controller uses two cells, number and flag
+- eeprom-length		: Set to the length of an EEPROM connected to the
+			  switch. Must be set if the switch can not detect
+			  the presence and/or size of a connected EEPROM,
+			  otherwise optional.
 - mdio			: Container of PHY and devices on the switches MDIO
 			  bus.
 - mdio?		: Container of PHYs and devices on the external MDIO
-- 
2.11.0

[PATCH 2/2] ARM: VF610: ZII devel b: Add switch eeprom-length properties

[Andrew Lunn]

Two of the Ethernet switches on this board have EEPROMs connected.
Add the eeprom-length property to the device tree, making it possible
to access the EEPROM using ethtool -e.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
index 37f95427616f..acdf12ad0622 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
@@ -78,6 +78,7 @@
 				interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				eeprom-length = <512>;
 
 				ports {
 					#address-cells = <1>;
@@ -163,6 +164,7 @@
 				interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				eeprom-length = <512>;
 
 				ports {
 					#address-cells = <1>;
-- 
2.11.0

Re: [PATCH 2/2] ARM: VF610: ZII devel b: Add switch eeprom-length properties

[Shawn Guo]

On Fri, May 26, 2017 at 01:44:44AM +0200, Andrew Lunn wrote:
> Two of the Ethernet switches on this board have EEPROMs connected.
> Add the eeprom-length property to the device tree, making it possible
> to access the EEPROM using ethtool -e.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Applied with a bit update on subject prefix.  Thanks.

Shawn

Re: [PATCH 0/2] Document and use eeprom-length property

[David Miller]

From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 26 May 2017 01:44:42 +0200

> The mv88e6xxx switch driver allows the size of the attached EEPROM to
> be described in DT. This property is missing from the binding
> documentation. Add it. And make use of it on the ZII Devel B board.
> 
> David, Shawn, please could you talk amongs yourself to decide who
> takes what.

I can take this if it works for Shawn, otherwise I'm also fine if Shawn
takes it and if so feel free to add my:

Acked-by: David S. Miller <davem@davemloft.net>

Re: [PATCH 0/2] Document and use eeprom-length property

[Shawn Guo]

On Fri, May 26, 2017 at 03:02:42PM -0400, David Miller wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Fri, 26 May 2017 01:44:42 +0200
> 
> > The mv88e6xxx switch driver allows the size of the attached EEPROM to
> > be described in DT. This property is missing from the binding
> > documentation. Add it. And make use of it on the ZII Devel B board.
> > 
> > David, Shawn, please could you talk amongs yourself to decide who
> > takes what.
> 
> I can take this if it works for Shawn, otherwise I'm also fine if Shawn
> takes it and if so feel free to add my:
> 
> Acked-by: David S. Miller <davem@davemloft.net>

Hi David,

I see these two patches can be applied separately, so I picked up 2/2
and left 1/2 to you.

Shawn

Re: [PATCH 0/2] Document and use eeprom-length property

[David Miller]

From: Shawn Guo <shawnguo@kernel.org>
Date: Sat, 27 May 2017 16:13:34 +0800

> On Fri, May 26, 2017 at 03:02:42PM -0400, David Miller wrote:
>> From: Andrew Lunn <andrew@lunn.ch>
>> Date: Fri, 26 May 2017 01:44:42 +0200
>> 
>> > The mv88e6xxx switch driver allows the size of the attached EEPROM to
>> > be described in DT. This property is missing from the binding
>> > documentation. Add it. And make use of it on the ZII Devel B board.
>> > 
>> > David, Shawn, please could you talk amongs yourself to decide who
>> > takes what.
>> 
>> I can take this if it works for Shawn, otherwise I'm also fine if Shawn
>> takes it and if so feel free to add my:
>> 
>> Acked-by: David S. Miller <davem@davemloft.net>
> 
> Hi David,
> 
> I see these two patches can be applied separately, so I picked up 2/2
> and left 1/2 to you.

Ok I applied 1/2, thanks.