Netdev List
 help / color / mirror / Atom feed
From: Yuval Mintz <Yuval.Mintz@cavium.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>,
	Yuval Mintz <Yuval.Mintz@cavium.com>
Subject: [PATCH net-next 03/10] qed: Don't inherit RoCE DCBx for V2
Date: Sun, 28 May 2017 18:01:53 +0300	[thread overview]
Message-ID: <1495983720-10853-4-git-send-email-Yuval.Mintz@cavium.com> (raw)
In-Reply-To: <1495983720-10853-1-git-send-email-Yuval.Mintz@cavium.com>

From: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>

Older firmware used by device didn't distinguish between RoCE and RoCE
V2 from DCBx configuration perspective, and as a result we've used to
take a the RoCE-related configuration and apply to it for both.

Since we now support configuring each its own values, there's no reason
to reflect [& configure] that both are using the same.

Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
---
 drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index af34638..e2a62c0 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -310,17 +310,6 @@ static bool qed_dcbx_roce_v2_tlv(u32 app_info_bitmap, u16 proto_id, bool ieee)
 		}
 	}
 
-	/* If RoCE-V2 TLV is not detected, driver need to use RoCE app
-	 * data for RoCE-v2 not the default app data.
-	 */
-	if (!p_data->arr[DCBX_PROTOCOL_ROCE_V2].update &&
-	    p_data->arr[DCBX_PROTOCOL_ROCE].update) {
-		tc = p_data->arr[DCBX_PROTOCOL_ROCE].tc;
-		priority = p_data->arr[DCBX_PROTOCOL_ROCE].priority;
-		qed_dcbx_update_app_info(p_data, p_hwfn, true, true,
-					 priority, tc, DCBX_PROTOCOL_ROCE_V2);
-	}
-
 	/* Update ramrod protocol data and hw_info fields
 	 * with default info when corresponding APP TLV's are not detected.
 	 * The enabled field has a different logic for ethernet as only for
-- 
1.9.3

  parent reply	other threads:[~2017-05-28 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 15:01 [PATCH net-next 00/10] qed: DCBx and Attentions series Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 01/10] qed: Add missing static/local dcbx info Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 02/10] qed: Correct DCBx update scheme Yuval Mintz
2017-05-28 15:58   ` kbuild test robot
2017-05-28 15:01 ` Yuval Mintz [this message]
2017-05-28 15:01 ` [PATCH net-next 04/10] qed: QL41xxx VF MSI-x table Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 05/10] qed: Support dynamic s-tag change Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 06/10] qed: Get rid of the attention-arrays Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 07/10] qed: Diffrentiate adapter-specific attentions Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 08/10] qed: Print multi-bit attentions properly Yuval Mintz
2017-05-28 15:01 ` [PATCH net-next 09/10] qed: Mask parities after occurance Yuval Mintz
2017-05-28 15:02 ` [PATCH net-next 10/10] qed: Cache alignemnt padding to match host Yuval Mintz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495983720-10853-4-git-send-email-Yuval.Mintz@cavium.com \
    --to=yuval.mintz@cavium.com \
    --cc=Sudarsana.Kalluru@cavium.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox