* [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations
@ 2017-05-30 17:43 Michael Kelley
2017-05-30 18:03 ` Joe Perches
2017-05-31 17:59 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Michael Kelley @ 2017-05-30 17:43 UTC (permalink / raw)
To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
Cc: Michael Kelley
Add direct #include statements for declarations of csum_tcpudp_magic()
and csum_ipv6_magic(). While the needed #include's are picked up
indirectly for the x86 architecture, they aren't on other
architectures, resulting in compile errors.
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
drivers/net/hyperv/netvsc_drv.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 4421a6d..ca952b3 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -37,6 +37,8 @@
#include <net/route.h>
#include <net/sock.h>
#include <net/pkt_sched.h>
+#include <asm/checksum.h>
+#include <net/ip6_checksum.h>
#include "hyperv_net.h"
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations
2017-05-30 17:43 [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Michael Kelley
@ 2017-05-30 18:03 ` Joe Perches
2017-05-31 17:59 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-05-30 18:03 UTC (permalink / raw)
To: mikelley, davem, netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
On Tue, 2017-05-30 at 10:43 -0700, Michael Kelley wrote:
> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
[]
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4421a6d..ca952b3 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -37,6 +37,8 @@
> #include <net/route.h>
> #include <net/sock.h>
> #include <net/pkt_sched.h>
> +#include <asm/checksum.h>
Maybe
#include <net/checksum.h>
instead?
> +#include <net/ip6_checksum.h>
>
> #include "hyperv_net.h"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations
2017-05-30 17:43 [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Michael Kelley
2017-05-30 18:03 ` Joe Perches
@ 2017-05-31 17:59 ` David Miller
2017-05-31 22:59 ` Joe Perches
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2017-05-31 17:59 UTC (permalink / raw)
To: mikelley
Cc: olaf, sthemmin, netdev, jasowang, linux-kernel, marcelo.cerri,
apw, devel, leann.ogasawara
From: Michael Kelley <mikelley@microsoft.com>
Date: Tue, 30 May 2017 10:43:04 -0700
> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
>
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations
2017-05-31 17:59 ` David Miller
@ 2017-05-31 22:59 ` Joe Perches
2017-05-31 23:25 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2017-05-31 22:59 UTC (permalink / raw)
To: David Miller, mikelley
Cc: netdev, linux-kernel, devel, olaf, apw, jasowang, leann.ogasawara,
marcelo.cerri, sthemmin
On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote:
> From: Michael Kelley <mikelley@microsoft.com>
> Date: Tue, 30 May 2017 10:43:04 -0700
>
> > Add direct #include statements for declarations of csum_tcpudp_magic()
> > and csum_ipv6_magic(). While the needed #include's are picked up
> > indirectly for the x86 architecture, they aren't on other
> > architectures, resulting in compile errors.
> >
> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
>
> Applied, thank you.
Did you apply this one or the v2?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations
2017-05-31 22:59 ` Joe Perches
@ 2017-05-31 23:25 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-05-31 23:25 UTC (permalink / raw)
To: joe
Cc: olaf, sthemmin, netdev, jasowang, linux-kernel, mikelley,
marcelo.cerri, apw, devel, leann.ogasawara
From: Joe Perches <joe@perches.com>
Date: Wed, 31 May 2017 15:59:31 -0700
> On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote:
>> From: Michael Kelley <mikelley@microsoft.com>
>> Date: Tue, 30 May 2017 10:43:04 -0700
>>
>> > Add direct #include statements for declarations of csum_tcpudp_magic()
>> > and csum_ipv6_magic(). While the needed #include's are picked up
>> > indirectly for the x86 architecture, they aren't on other
>> > architectures, resulting in compile errors.
>> >
>> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
>>
>> Applied, thank you.
>
> Did you apply this one or the v2?
I got v2 which used net/checksum.h et al.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-31 23:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-30 17:43 [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Michael Kelley
2017-05-30 18:03 ` Joe Perches
2017-05-31 17:59 ` David Miller
2017-05-31 22:59 ` Joe Perches
2017-05-31 23:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).