From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Xin Long <lucien.xin@gmail.com>,
Andrey Konovalov <andreyknvl@google.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv4: igmp: fix a use after free
Date: Thu, 08 Jun 2017 18:37:07 -0700 [thread overview]
Message-ID: <1496972227.736.90.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <CAM_iQpVu+sF4zGhGCYDV6J-+rN69zuMGGvGJpLajhYS-QfdUfQ@mail.gmail.com>
On Thu, 2017-06-08 at 17:59 -0700, Cong Wang wrote:
> On Thu, Jun 8, 2017 at 1:33 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > I mentioned (in https://lkml.org/lkml/2017/5/31/619 ) that we might need
> > to defer freeing after rcu grace period but for some reason decided it
> > was not needed.
>
> This one makes sense, it is the second time I saw the use-after-free
> in igmp code, both are because we don't respect the RCU rule to free
> an element in the list.
>
> >
> > What about :
>
> But not sure if all ip_ma_put() callers want ip_mc_clear_src().
That would lead to a memory leak if this was the case ?
next prev parent reply other threads:[~2017-06-09 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 9:46 net/ipv4: use-after-free in add_grec Andrey Konovalov
2017-05-31 16:12 ` Eric Dumazet
2017-05-31 23:49 ` Cong Wang
2017-05-31 23:55 ` Eric Dumazet
2017-06-01 0:13 ` Eric Dumazet
2017-06-01 12:01 ` Andrey Konovalov
2017-06-08 13:43 ` [PATCH net] ipv4: igmp: fix a use after free Eric Dumazet
2017-06-08 18:22 ` Xin Long
2017-06-08 20:33 ` Eric Dumazet
2017-06-09 0:59 ` Cong Wang
2017-06-09 1:37 ` Eric Dumazet [this message]
2017-06-09 6:05 ` Cong Wang
2017-06-09 6:27 ` Xin Long
2017-06-09 6:24 ` Xin Long
2017-06-09 15:56 ` Eric Dumazet
2017-06-09 17:01 ` Cong Wang
2017-06-09 18:05 ` Xin Long
2017-06-09 21:35 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496972227.736.90.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox