* [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static
@ 2017-06-13 13:03 Colin King
2017-06-13 14:16 ` Andy Shevchenko
2017-06-13 17:56 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2017-06-13 13:03 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S . Miller, Daode Huang,
Kejian Yan, Andy Shevchenko, oulijun, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.
Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index 6b15a507999c..7a8addda726e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -29,7 +29,7 @@ enum _dsm_rst_type {
HNS_ROCE_RESET_FUNC = 0x7,
};
-const guid_t hns_dsaf_acpi_dsm_guid =
+static const guid_t hns_dsaf_acpi_dsm_guid =
GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static
2017-06-13 13:03 [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Colin King
@ 2017-06-13 14:16 ` Andy Shevchenko
2017-06-13 17:56 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2017-06-13 14:16 UTC (permalink / raw)
To: Colin King, Yisen Zhuang, Salil Mehta, David S . Miller,
Daode Huang, Kejian Yan, oulijun, netdev
Cc: kernel-janitors, linux-kernel
On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
> scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be
> static?"
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> index 6b15a507999c..7a8addda726e 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> @@ -29,7 +29,7 @@ enum _dsm_rst_type {
> HNS_ROCE_RESET_FUNC = 0x7,
> };
>
> -const guid_t hns_dsaf_acpi_dsm_guid =
> +static const guid_t hns_dsaf_acpi_dsm_guid =
> GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
> 0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static
2017-06-13 13:03 [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Colin King
2017-06-13 14:16 ` Andy Shevchenko
@ 2017-06-13 17:56 ` David Miller
2017-06-13 19:24 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2017-06-13 17:56 UTC (permalink / raw)
To: colin.king
Cc: yisen.zhuang, salil.mehta, huangdaode, yankejian,
andriy.shevchenko, oulijun, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 13 Jun 2017 14:03:21 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
> scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
That symbol doesn't even exist in th net-next tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static
2017-06-13 17:56 ` David Miller
@ 2017-06-13 19:24 ` Andy Shevchenko
2017-06-13 20:40 ` Colin Ian King
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2017-06-13 19:24 UTC (permalink / raw)
To: David Miller, Christoph Hellwig
Cc: Colin King, Yisen Zhuang, salil.mehta, huangdaode, yankejian,
Andy Shevchenko, oulijun, netdev, kernel-janitors,
linux-kernel@vger.kernel.org
On Tue, Jun 13, 2017 at 8:56 PM, David Miller <davem@davemloft.net> wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Tue, 13 Jun 2017 14:03:21 +0100
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
>> scope, so make it static.
>>
>> Cleans up sparse warning:
>> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> That symbol doesn't even exist in th net-next tree.
It looks like the patch is done against UUID tree.
Cc'ed Christoph.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static
2017-06-13 19:24 ` Andy Shevchenko
@ 2017-06-13 20:40 ` Colin Ian King
0 siblings, 0 replies; 5+ messages in thread
From: Colin Ian King @ 2017-06-13 20:40 UTC (permalink / raw)
To: Andy Shevchenko, David Miller, Christoph Hellwig
Cc: Yisen Zhuang, salil.mehta, huangdaode, yankejian, Andy Shevchenko,
oulijun, netdev, kernel-janitors, linux-kernel@vger.kernel.org
On 13/06/17 20:24, Andy Shevchenko wrote:
> On Tue, Jun 13, 2017 at 8:56 PM, David Miller <davem@davemloft.net> wrote:
>> From: Colin King <colin.king@canonical.com>
>> Date: Tue, 13 Jun 2017 14:03:21 +0100
>>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
>>> scope, so make it static.
>>>
>>> Cleans up sparse warning:
>>> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> That symbol doesn't even exist in th net-next tree.
>
> It looks like the patch is done against UUID tree.
> Cc'ed Christoph.
>
Sorry, I messed up on determining the original tree it came from in
linux-next when I looked at the output from get_maintainer.pl
Colin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-13 20:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-13 13:03 [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Colin King
2017-06-13 14:16 ` Andy Shevchenko
2017-06-13 17:56 ` David Miller
2017-06-13 19:24 ` Andy Shevchenko
2017-06-13 20:40 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).