From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: make skb_put_zero() return void
Date: Thu, 15 Jun 2017 23:28:28 +0200 [thread overview]
Message-ID: <1497562108.2518.12.camel@sipsolutions.net> (raw)
In-Reply-To: <20170615.172637.978834439625255398.davem@davemloft.net>
On Thu, 2017-06-15 at 17:26 -0400, David Miller wrote:
>
> > *skb_put(skb, 1) = 'x';
> >
> > Seems pretty unlikely we have that, and in any case the compiler
> would
> > warn (error?) there if skb_put() becomes void.
>
> Actually I am pretty sure I've seen a pattern like that somewhere. :-
> )
Yeah, there are actually a ton of them, and oddly enough my spatch is
failing to catch _one_ of them?? Still refining it :)
johannes
next prev parent reply other threads:[~2017-06-15 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 20:17 [PATCH] skbuff: make skb_put_zero() return void Johannes Berg
2017-06-14 20:36 ` Joe Perches
2017-06-14 20:40 ` Johannes Berg
2017-06-14 21:18 ` Joe Perches
2017-06-15 22:17 ` Johannes Berg
2017-06-15 22:55 ` Joe Perches
2017-06-15 16:18 ` David Miller
2017-06-15 19:28 ` Johannes Berg
2017-06-15 21:26 ` David Miller
2017-06-15 21:28 ` Johannes Berg [this message]
2017-06-15 22:17 ` Joe Perches
2017-06-15 22:21 ` Johannes Berg
2017-06-15 22:30 ` Joe Perches
2017-06-15 22:23 ` Johannes Berg
2017-06-15 22:38 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497562108.2518.12.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).