From: Serhey Popovych <serhe.popovych@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH] loopback: Force LOOPBACK_IFINDEX for registration
Date: Fri, 16 Jun 2017 15:10:03 +0300 [thread overview]
Message-ID: <1497615003-24762-1-git-send-email-serhe.popovych@gmail.com> (raw)
Now with commit 9c7dafb (net: Allow to create links with
given ifindex) support registration of network devices
with specific ifindex is added.
We can force loopback network device index before call to
register_netdev() to ensure we always configure it with
LOOPBACK_IFINDEX.
Kill BUG_ON() since system can continue without network
namespace failed in loopback init path, unless it is
init_net namespace where we panic() anyway.
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
---
drivers/net/loopback.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 3061249..d7233aa 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -210,12 +210,13 @@ static __net_init int loopback_net_init(struct net *net)
if (!dev)
goto out;
+ dev->ifindex = LOOPBACK_IFINDEX;
+
dev_net_set(dev, net);
err = register_netdev(dev);
if (err)
goto out_free_netdev;
- BUG_ON(dev->ifindex != LOOPBACK_IFINDEX);
net->loopback_dev = dev;
return 0;
--
1.8.3.1
next reply other threads:[~2017-06-16 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 12:10 Serhey Popovych [this message]
2017-06-17 11:21 ` [PATCH] loopback: Force LOOPBACK_IFINDEX for registration Sergei Shtylyov
2017-06-19 18:41 ` David Miller
2017-06-20 10:32 ` Serhey Popovych
2017-06-21 9:35 ` Serhey Popovych
2017-06-21 15:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497615003-24762-1-git-send-email-serhe.popovych@gmail.com \
--to=serhe.popovych@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).