From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: davem@davemloft.net, linville@tuxdriver.com
Cc: netdev@vger.kernel.org, vidya.chowdary@gmail.com,
dustin@cumulusnetworks.com, olson@cumulusnetworks.com,
leedom@chelsio.com, manojmalviya@chelsio.com,
santosh@chelsio.com, yuval.mintz@qlogic.com, odedw@mellanox.com,
ariela@mellanox.com, galp@mellanox.com,
jeffrey.t.kirsher@intel.com
Subject: [PATCH net-next 3/3] cxgb4: ethtool forward error correction management support
Date: Sat, 24 Jun 2017 12:19:45 -0700 [thread overview]
Message-ID: <1498331985-8525-4-git-send-email-roopa@cumulusnetworks.com> (raw)
In-Reply-To: <1498331985-8525-1-git-send-email-roopa@cumulusnetworks.com>
From: Casey Leedom <leedom@chelsio.com>
Signed-off-by: Casey Leedom <leedom@chelsio.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 +++++++++++++++++++++
1 file changed, 100 insertions(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
index e9bab72..76ea609 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
@@ -801,6 +801,104 @@ static int set_link_ksettings(struct net_device *dev,
return ret;
}
+/* Translate the Firmware FEC value into the ethtool value. */
+static inline unsigned int fwcap_to_eth_fec(unsigned int fw_fec)
+{
+ unsigned int eth_fec = 0;
+
+ if (fw_fec & FW_PORT_CAP_FEC_RS)
+ eth_fec |= ETHTOOL_FEC_RS;
+ if (fw_fec & FW_PORT_CAP_FEC_BASER_RS)
+ eth_fec |= ETHTOOL_FEC_BASER;
+
+ /* if nothing is set, then FEC is off */
+ if (!eth_fec)
+ eth_fec = ETHTOOL_FEC_OFF;
+
+ return eth_fec;
+}
+
+/* Translate Common Code FEC value into ethtool value. */
+static inline unsigned int cc_to_eth_fec(unsigned int cc_fec)
+{
+ unsigned int eth_fec = 0;
+
+ if (cc_fec & FEC_AUTO)
+ eth_fec |= ETHTOOL_FEC_AUTO;
+ if (cc_fec & FEC_RS)
+ eth_fec |= ETHTOOL_FEC_RS;
+ if (cc_fec & FEC_BASER_RS)
+ eth_fec |= ETHTOOL_FEC_BASER;
+
+ /* if nothing is set, then FEC is off */
+ if (!eth_fec)
+ eth_fec = ETHTOOL_FEC_OFF;
+
+ return eth_fec;
+}
+
+/* Translate ethtool FEC value into Common Code value. */
+static inline unsigned int eth_to_cc_fec(unsigned int eth_fec)
+{
+ unsigned int cc_fec = 0;
+
+ if (eth_fec & ETHTOOL_FEC_OFF)
+ return cc_fec;
+
+ if (eth_fec & ETHTOOL_FEC_AUTO)
+ cc_fec |= FEC_AUTO;
+ if (eth_fec & ETHTOOL_FEC_RS)
+ cc_fec |= FEC_RS;
+ if (eth_fec & ETHTOOL_FEC_BASER)
+ cc_fec |= FEC_BASER_RS;
+
+ return cc_fec;
+}
+
+static int get_fecparam(struct net_device *dev, struct ethtool_fecparam *fec)
+{
+ const struct port_info *pi = netdev_priv(dev);
+ const struct link_config *lc = &pi->link_cfg;
+
+ /* Translate the Firmware FEC Support into the ethtool value. We
+ * always support IEEE 802.3 "automatic" selection of Link FEC type if
+ * any FEC is supported.
+ */
+ fec->fec = fwcap_to_eth_fec(lc->supported);
+ if (fec->fec != ETHTOOL_FEC_OFF)
+ fec->fec |= ETHTOOL_FEC_AUTO;
+
+ /* Translate the current internal FEC parameters into the
+ * ethtool values.
+ */
+ fec->active_fec = cc_to_eth_fec(lc->fec);
+
+ return 0;
+}
+
+static int set_fecparam(struct net_device *dev, struct ethtool_fecparam *fec)
+{
+ struct port_info *pi = netdev_priv(dev);
+ struct link_config *lc = &pi->link_cfg;
+ struct link_config old_lc;
+ int ret;
+
+ /* Save old Link Configuration in case the L1 Configure below
+ * fails.
+ */
+ old_lc = *lc;
+
+ /* Try to perform the L1 Configure and return the result of that
+ * effort. If it fails, revert the attempted change.
+ */
+ lc->requested_fec = eth_to_cc_fec(fec->fec);
+ ret = t4_link_l1cfg(pi->adapter, pi->adapter->mbox,
+ pi->tx_chan, lc);
+ if (ret)
+ *lc = old_lc;
+ return ret;
+}
+
static void get_pauseparam(struct net_device *dev,
struct ethtool_pauseparam *epause)
{
@@ -1238,6 +1336,8 @@ static int get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *info,
static const struct ethtool_ops cxgb_ethtool_ops = {
.get_link_ksettings = get_link_ksettings,
.set_link_ksettings = set_link_ksettings,
+ .get_fecparam = get_fecparam,
+ .set_fecparam = set_fecparam,
.get_drvinfo = get_drvinfo,
.get_msglevel = get_msglevel,
.set_msglevel = set_msglevel,
--
2.1.4
next prev parent reply other threads:[~2017-06-24 19:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 19:19 [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Roopa Prabhu
2017-06-24 19:19 ` [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes Roopa Prabhu
2017-06-25 13:38 ` Gal Pressman
2017-06-28 5:46 ` Dustin Byford
2017-06-29 15:49 ` Gal Pressman
2017-06-27 10:22 ` Jakub Kicinski
2017-06-28 6:27 ` Dustin Byford
2017-06-28 6:41 ` Jakub Kicinski
2017-06-28 13:41 ` Andrew Lunn
2017-06-28 21:47 ` Dustin Byford
2017-06-29 1:00 ` Jakub Kicinski
2017-07-06 18:53 ` Casey Leedom
2017-07-06 19:02 ` Jakub Kicinski
2017-07-06 21:06 ` Wyborny, Carolyn
2017-07-06 21:53 ` Casey Leedom
2017-07-06 22:16 ` Wyborny, Carolyn
2017-07-06 22:36 ` Andrew Lunn
2017-07-06 22:37 ` Casey Leedom
2017-07-06 22:33 ` Andrew Lunn
2017-07-06 22:47 ` Casey Leedom
2017-07-06 23:15 ` Andrew Lunn
2017-07-06 23:27 ` Jakub Kicinski
2017-07-06 23:39 ` Casey Leedom
2017-07-07 0:56 ` Andrew Lunn
2017-07-07 1:38 ` Dave Olson
2017-07-06 22:43 ` Jakub Kicinski
2017-07-06 22:57 ` Casey Leedom
2017-06-29 13:30 ` Andrew Lunn
2017-06-24 19:19 ` [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link Roopa Prabhu
2017-06-27 3:16 ` David Miller
2017-06-24 19:19 ` Roopa Prabhu [this message]
2017-06-24 21:47 ` [PATCH net-next 0/3] ethtool: support for forward error correction mode setting " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498331985-8525-4-git-send-email-roopa@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=ariela@mellanox.com \
--cc=davem@davemloft.net \
--cc=dustin@cumulusnetworks.com \
--cc=galp@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=leedom@chelsio.com \
--cc=linville@tuxdriver.com \
--cc=manojmalviya@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=odedw@mellanox.com \
--cc=olson@cumulusnetworks.com \
--cc=santosh@chelsio.com \
--cc=vidya.chowdary@gmail.com \
--cc=yuval.mintz@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).