* [PATCH v2 00/10] Constify attribute_group structures
@ 2017-07-11 7:36 Arvind Yadav
2017-07-11 7:36 ` [PATCH v2 09/10] net: bonding: constify " Arvind Yadav
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-11 7:36 UTC (permalink / raw)
To: j.vosburgh, vfalico, andy; +Cc: netdev, linux-kernel
attribute_groups are not supposed to change at runtime. So mark the
non-const structs as const.
Arvind Yadav (10):
[PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.
[PATCH v2 02/10] net: can: at91_can: constify attribute_group structures.
[PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures.
[PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
[PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
[PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.
[PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.
[PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures.
[PATCH v2 09/10] net: bonding: constify attribute_group structures.
[PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures.
drivers/net/arcnet/com20020-pci.c | 2 +-
drivers/net/bonding/bond_sysfs.c | 2 +-
drivers/net/can/at91_can.c | 2 +-
drivers/net/can/janz-ican3.c | 2 +-
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 ++++++--
drivers/net/usb/cdc_ncm.c | 2 +-
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +-
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +-
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
10 files changed, 15 insertions(+), 11 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 09/10] net: bonding: constify attribute_group structures.
2017-07-11 7:36 [PATCH v2 00/10] Constify attribute_group structures Arvind Yadav
@ 2017-07-11 7:36 ` Arvind Yadav
0 siblings, 0 replies; 2+ messages in thread
From: Arvind Yadav @ 2017-07-11 7:36 UTC (permalink / raw)
To: j.vosburgh, vfalico, andy; +Cc: netdev, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/netdevice.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
4512 1472 0 5984 1760 drivers/net/bonding/bond_sysfs.o
File size After adding 'const':
text data bss dec hex filename
4576 1408 0 5984 1760 drivers/net/bonding/bond_sysfs.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
drivers/net/bonding/bond_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 770623a..040b493 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -759,7 +759,7 @@ static DEVICE_ATTR(ad_user_port_key, S_IRUGO | S_IWUSR,
NULL,
};
-static struct attribute_group bonding_group = {
+static const struct attribute_group bonding_group = {
.name = "bonding",
.attrs = per_bond_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-11 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-11 7:36 [PATCH v2 00/10] Constify attribute_group structures Arvind Yadav
2017-07-11 7:36 ` [PATCH v2 09/10] net: bonding: constify " Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).