* [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions
[not found] <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>
@ 2017-07-12 8:04 ` Benjamin Gaignard
2017-07-12 20:01 ` Michael Chan
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Gaignard @ 2017-07-12 8:04 UTC (permalink / raw)
To: benjamin.gaignard; +Cc: linaro-kernel, Michael Chan, netdev, linux-kernel
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they
rely on 32bits variables and that will make rtc break in y2038/2016.
Stop using those two functions to safer 64bits ones.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
CC: Michael Chan <michael.chan@broadcom.com>
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b56c54d..9fef202 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4703,7 +4703,7 @@ int bnxt_hwrm_fw_set_time(struct bnxt *bp)
return -EOPNOTSUPP;
do_gettimeofday(&tv);
- rtc_time_to_tm(tv.tv_sec, &tm);
+ rtc_time64_to_tm(tv.tv_sec, &tm);
bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_FW_SET_TIME, -1, -1);
req.year = cpu_to_le16(1900 + tm.tm_year);
req.month = 1 + tm.tm_mon;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions
2017-07-12 8:04 ` [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions Benjamin Gaignard
@ 2017-07-12 20:01 ` Michael Chan
0 siblings, 0 replies; 2+ messages in thread
From: Michael Chan @ 2017-07-12 20:01 UTC (permalink / raw)
To: Benjamin Gaignard; +Cc: linaro-kernel, Netdev, open list
On Wed, Jul 12, 2017 at 1:04 AM, Benjamin Gaignard
<benjamin.gaignard@linaro.org> wrote:
> rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they
> rely on 32bits variables and that will make rtc break in y2038/2016.
> Stop using those two functions to safer 64bits ones.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> CC: Michael Chan <michael.chan@broadcom.com>
> CC: netdev@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
Acked-by: Michael Chan <michael.chan@broadcom.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-12 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>
2017-07-12 8:04 ` [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions Benjamin Gaignard
2017-07-12 20:01 ` Michael Chan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).