From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jose Abreu <Jose.Abreu@synopsys.com>
Subject: Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up
Date: Fri, 18 May 2018 10:17:25 +0100
Message-ID: <14b68a40-bba5-b3dd-4168-579de5f0c658@synopsys.com>
References: <64edab6c-0bbf-fd8a-6be6-aaf802f6d12f@gmail.com>
 <a36d9afa-6939-2695-5f31-bc8777b5f27c@synopsys.com>
 <20180517.144117.1704300189822624802.davem@davemloft.net>
 <20180517.144709.898265283908363051.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-7"
Content-Transfer-Encoding: 8bit
Cc: <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
        <Joao.Pinto@synopsys.com>, <Vitor.Soares@synopsys.com>,
        <peppe.cavallaro@st.com>, <alexandre.torgue@st.com>
To: David Miller <davem@davemloft.net>, <Jose.Abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtprelay6.synopsys.com ([198.182.37.59]:56751 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752804AbeERJRf (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 18 May 2018 05:17:35 -0400
Received: from mailhost.synopsys.com (mailhost3.synopsys.com [10.12.238.238])
        by smtprelay.synopsys.com (Postfix) with ESMTP id C573F1E04F9
        for <netdev@vger.kernel.org>; Fri, 18 May 2018 11:17:33 +0200 (CEST)
In-Reply-To: <20180517.144709.898265283908363051.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi David,

On 17-05-2018 19:47, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 17 May 2018 14:41:17 -0400 (EDT)
>
>> From: Jose Abreu <Jose.Abreu@synopsys.com>
>> Date: Thu, 17 May 2018 14:24:42 +0100
>>
>>> Given that the difference between better/worst is < 1%, I think
>>> we can conclude patches 3-13 don't affect the overall
>>> performance. I didn't profile the cache hits/miss though ...
>> Ok, thanks for making an effort to look into this more thoroughly.
>>
>> I'll apply this series to net-next, thank you.
> Sorry, I had to revert.
>
> It is one thing to say that you lack the hardware to physically test
> the changes on all chip types.
>
> It is yet another to not even test the build properly:
>
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:494:10: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .init = sun8i_dwmac_dma_init,
>           ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:494:10: note: (near initialization for ¡sun8i_dwmac_dma_ops.init¢)
> cc1: some warnings being treated as errors

Yeah, I was missing CONFIG_COMPILE_TEST=y. Sorry about that. Will
respin.

Thanks and Best Regards,
Jose Miguel Abreu