From: Jacob Keller <jacob.e.keller@intel.com>
To: Paolo Abeni <pabeni@redhat.com>, Petr Oros <poros@redhat.com>,
<netdev@vger.kernel.org>
Cc: <ivecera@redhat.com>, <aleksandr.loktionov@intel.com>,
<shaojijie@huawei.com>, Tony Nguyen <anthony.l.nguyen@intel.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] iavf: fix deadlock in reset handling
Date: Wed, 11 Feb 2026 10:50:03 -0800 [thread overview]
Message-ID: <14cccd55-f737-428b-91da-1daf68d4f899@intel.com> (raw)
In-Reply-To: <d97612d0-09ed-4895-a22a-6fa73abfbbf5@redhat.com>
On 2/11/2026 3:50 AM, Paolo Abeni wrote:
> On 2/7/26 11:22 AM, Petr Oros wrote:
>> -/**
>> - * iavf_wait_for_reset - Wait for reset to finish.
>> - * @adapter: board private structure
>> - *
>> - * Returns 0 if reset finished successfully, negative on timeout or interrupt.
>> - */
>> -int iavf_wait_for_reset(struct iavf_adapter *adapter)
>> -{
>> - int ret = wait_event_interruptible_timeout(adapter->reset_waitqueue,
>> - !iavf_is_reset_in_progress(adapter),
>> - msecs_to_jiffies(5000));
>
> AFAICS, after this change nobody waits anymore on reset_waitqueue, do we
> still need such wait queue head? I think a bunch of additional code
> could be dropped.
>
> Thanks,
>
> Paolo
>
Yea, that seems correct. We could do that cleanup through next instead
if we want to keep this patch smaller and focused on the fix. I don't
mind either way.
Thanks,
Jake
next prev parent reply other threads:[~2026-02-11 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 10:22 [PATCH net v2] iavf: fix deadlock in reset handling Petr Oros
2026-02-09 7:15 ` Loktionov, Aleksandr
2026-02-09 23:59 ` Jacob Keller
2026-02-10 14:58 ` Przemek Kitszel
2026-02-11 11:50 ` Paolo Abeni
2026-02-11 18:50 ` Jacob Keller [this message]
2026-02-11 19:18 ` [PATCH net v3] iavf: fix incorrect reset handling in callbacks Petr Oros
2026-02-13 10:29 ` Przemek Kitszel
2026-02-23 16:10 ` [Intel-wired-lan] " Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14cccd55-f737-428b-91da-1daf68d4f899@intel.com \
--to=jacob.e.keller@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
--cc=shaojijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox