From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tipi-net.de (mail.tipi-net.de [194.13.80.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E783B6368; Tue, 28 Apr 2026 21:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.13.80.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777411568; cv=none; b=ilWOWGslA8Yw9Lwz8aIua4ctsx0jIRhbn7UbkWOMXeuotapKdjJ7obWHbt8htVDN2t67+mEcsYulK2AjL3oUJ+Dp4XKfR0XyqJRp/3aKb5IFCG0Xf+PZwVnThNcNtyE8aufsgidnH0Mjh8UEkfBuCzUgUV0EPzXDppQk77VXukY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777411568; c=relaxed/simple; bh=qT6eeV8jKzV5KexbApZcbERdIgZpnNebPp7XKB/jen0=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=qE00K4yTgbtxODiOiG1aGSBdwu5JWLHQEOgU9IsHwU75GmLY3EGlPYXu18dWyHniGIdwc0OwzGpyhiRUogvY724/ETgEEHwaRbyNJbw7PWZYXUK1OptNwWOyVGlBv4Rm8ZQ8+bjDy2QD4GdfUPwey7Go/8aHB08aVxT++w1jbPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de; spf=pass smtp.mailfrom=tipi-net.de; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b=KGGCcZpB; arc=none smtp.client-ip=194.13.80.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b="KGGCcZpB" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 03AEEA543F; Tue, 28 Apr 2026 23:26:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tipi-net.de; s=dkim; t=1777411565; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=yWI7d0UlcsNsk8LNzdc3Q9Xy20Ewp7Zy6qd2omyAEVs=; b=KGGCcZpBSWgynxWxrQyR714PFgzem9mUbT46sI/62mEgGAdAB46zDWVx5D5SySOnbZFuxs fFfjq5nazpFTWejobnlA1E98n/UuA4Qgi6Z8cXafZim3tfPs/0OumO6q0qa6I2449qKE2J ofQQ734kO2Ek5F35uP18pGbHs93+j63gY6y+aD4MGTZ+7adEXx1FR9lIH2rn4NiCcTMEUU CiH8rZkRpDDP2ucgdd3GzR6zTJ8E4gd9ozI3NFydekIRok5ag04tJndY+LJVmuZKqdH8OF Niq4kRB7E4aLtjlXvQdfTuBVU/Umkpf2nyTun4DjKUvMLqS22IW4WwGeB1ERJQ== Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 28 Apr 2026 23:26:04 +0200 From: Nicolai Buchwitz To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= Cc: Nicolas Ferre , Claudiu Beznea , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Haavard Skinnemoen , Jeff Garzik , Paolo Valerio , Conor Dooley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Kondratiev , Gregory CLEMENT , =?UTF-8?Q?Beno=C3=AEt_Monin?= , Tawfik Bayouk , Thomas Petazzoni , Maxime Chevallier , stable@vger.kernel.org Subject: Re: [PATCH net v2 4/4] net: macb: increment stats.tx_dropped on DMA map error In-Reply-To: <20260428-macb-drop-tx-v2-4-647f5199d8df@bootlin.com> References: <20260428-macb-drop-tx-v2-0-647f5199d8df@bootlin.com> <20260428-macb-drop-tx-v2-4-647f5199d8df@bootlin.com> Message-ID: <14d3fe9ca9491f8f60adcfbd0741e886@tipi-net.de> X-Sender: nb@tipi-net.de Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On 28.4.2026 18:33, Théo Lebrun wrote: > On .ndo_start_xmit() and DMA mapping failure, increment the Tx dropped > statistics counter by one. > > Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver") > Cc: stable@vger.kernel.org > Signed-off-by: Théo Lebrun > --- > [...] Reviewed-by: Nicolai Buchwitz