From: John Fastabend <john.fastabend@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org
Subject: Re: [bpf PATCH] bpf: avoid kcm psock use and tcp_bpf from colliding
Date: Thu, 30 Aug 2018 17:24:03 -0700 [thread overview]
Message-ID: <14e7eb8a-afcd-4b42-cece-ebd2f4641458@gmail.com> (raw)
In-Reply-To: <20180830223325.11399.82496.stgit@john-Precision-Tower-5810>
On 08/30/2018 03:33 PM, John Fastabend wrote:
> Currently we check sk_user_data is non NULL to determine if the sk
> exists in a map. However, this is not sufficient to ensure the psock
> is not in use by another (non-ULP TCP) user, such as kcm. To avoid
> this when adding a sock to a map also verify it is of the correct ULP
> type.
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
> ---
I'll send a v2 of this we have one more spot we need to check
the psock type in the error path.
Thanks,
John
prev parent reply other threads:[~2018-08-31 4:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 22:33 [bpf PATCH] bpf: avoid kcm psock use and tcp_bpf from colliding John Fastabend
2018-08-31 0:24 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14e7eb8a-afcd-4b42-cece-ebd2f4641458@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox