From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Bhole Subject: Re: [RFC v2 bpf-next 2/5] bpf: return EOPNOTSUPP when map lookup isn't supported Date: Fri, 5 Oct 2018 09:16:04 +0900 Message-ID: <14f9b4ae-b1f8-d50c-fdc8-d357199cabc0@lab.ntt.co.jp> References: <20181002053519.8000-1-bhole_prashant_q7@lab.ntt.co.jp> <20181002053519.8000-3-bhole_prashant_q7@lab.ntt.co.jp> <20181005001043.btwv2k7fbp7gfcbv@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , "David S . Miller" , Quentin Monnet , netdev@vger.kernel.org To: Alexei Starovoitov Return-path: Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:58658 "EHLO tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbeJEHNQ (ORCPT ); Fri, 5 Oct 2018 03:13:16 -0400 In-Reply-To: <20181005001043.btwv2k7fbp7gfcbv@ast-mbp.dhcp.thefacebook.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/5/2018 9:10 AM, Alexei Starovoitov wrote: > On Tue, Oct 02, 2018 at 02:35:16PM +0900, Prashant Bhole wrote: >> Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below >> map types: >> - BPF_MAP_TYPE_PROG_ARRAY >> - BPF_MAP_TYPE_STACK_TRACE >> - BPF_MAP_TYPE_XSKMAP >> - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE_SOCKHASH >> >> Signed-off-by: Prashant Bhole >> --- >> kernel/bpf/arraymap.c | 2 +- >> kernel/bpf/sockmap.c | 2 +- >> kernel/bpf/stackmap.c | 2 +- >> kernel/bpf/xskmap.c | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c >> index dded84cbe814..24583da9ffd1 100644 >> --- a/kernel/bpf/arraymap.c >> +++ b/kernel/bpf/arraymap.c >> @@ -449,7 +449,7 @@ static void fd_array_map_free(struct bpf_map *map) >> >> static void *fd_array_map_lookup_elem(struct bpf_map *map, void *key) >> { >> - return NULL; >> + return ERR_PTR(-EOPNOTSUPP); > > last time we discussed that the verifier should make sure that > lookup is not called from bpf program for these map types. > I'd like to see test cases in test_verifier.c for these map types > to make sure we don't introduce crashes. Hi Alexei, Patch 05/05 adds such tests in test_verifier.c. Please review those changes. Thank you. -Prashant