* [PATCH 01/10] isdn: hisax: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 02/10] isdn: hisax: hfc4s8s_l1: " Arvind Yadav
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
13686 2064 4416 20166 4ec6 drivers/isdn/hisax/config.o
File size After adding 'const':
text data bss dec hex filename
15030 720 4416 20166 4ec6 drivers/isdn/hisax/config.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hisax/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index c7d6867..7108bdb8 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -1909,7 +1909,7 @@ static void EChannel_proc_rcv(struct hisax_d_if *d_if)
#ifdef CONFIG_PCI
#include <linux/pci.h>
-static struct pci_device_id hisax_pci_tbl[] __used = {
+static const struct pci_device_id hisax_pci_tbl[] __used = {
#ifdef CONFIG_HISAX_FRITZPCI
{PCI_VDEVICE(AVM, PCI_DEVICE_ID_AVM_A1) },
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 02/10] isdn: hisax: hfc4s8s_l1: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
2017-07-15 4:25 ` [PATCH 01/10] isdn: hisax: constify pci_device_id Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 03/10] isdn: hisax: hisax_fcpcipnp: " Arvind Yadav
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
10512 536 4 11052 2b2c drivers/isdn/hisax/hfc4s8s_l1.o
File size After adding 'const':
text data bss dec hex filename
10672 376 4 11052 2b2c drivers/isdn/hisax/hfc4s8s_l1.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hisax/hfc4s8s_l1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index 90f051c..9090cc1 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -86,7 +86,7 @@ typedef struct {
char *device_name;
} hfc4s8s_param;
-static struct pci_device_id hfc4s8s_ids[] = {
+static const struct pci_device_id hfc4s8s_ids[] = {
{.vendor = PCI_VENDOR_ID_CCD,
.device = PCI_DEVICE_ID_4S,
.subvendor = 0x1397,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 03/10] isdn: hisax: hisax_fcpcipnp: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
2017-07-15 4:25 ` [PATCH 01/10] isdn: hisax: constify pci_device_id Arvind Yadav
2017-07-15 4:25 ` [PATCH 02/10] isdn: hisax: hfc4s8s_l1: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 04/10] isdn: eicon: " Arvind Yadav
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5989 576 0 6565 19a5 isdn/hisax/hisax_fcpcipnp.o
File size After adding 'const':
text data bss dec hex filename
6085 480 0 6565 19a5 isdn/hisax/hisax_fcpcipnp.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hisax/hisax_fcpcipnp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c
index 5a9f39e..e4f7573 100644
--- a/drivers/isdn/hisax/hisax_fcpcipnp.c
+++ b/drivers/isdn/hisax/hisax_fcpcipnp.c
@@ -52,7 +52,7 @@ module_param(debug, int, 0);
MODULE_AUTHOR("Kai Germaschewski <kai.germaschewski@gmx.de>/Karsten Keil <kkeil@suse.de>");
MODULE_DESCRIPTION("AVM Fritz!PCI/PnP ISDN driver");
-static struct pci_device_id fcpci_ids[] = {
+static const struct pci_device_id fcpci_ids[] = {
{ .vendor = PCI_VENDOR_ID_AVM,
.device = PCI_DEVICE_ID_AVM_A1,
.subvendor = PCI_ANY_ID,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 04/10] isdn: eicon: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (2 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 03/10] isdn: hisax: hisax_fcpcipnp: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 05/10] isdn: mISDN: netjet: " Arvind Yadav
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
6224 655 8 6887 1ae7 isdn/hardware/eicon/divasmain.o
File size After adding 'const':
text data bss dec hex filename
6608 271 8 6887 1ae7 isdn/hardware/eicon/divasmain.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/eicon/divasmain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/eicon/divasmain.c b/drivers/isdn/hardware/eicon/divasmain.c
index 8b7ad4f..b2023e0 100644
--- a/drivers/isdn/hardware/eicon/divasmain.c
+++ b/drivers/isdn/hardware/eicon/divasmain.c
@@ -110,7 +110,7 @@ typedef struct _diva_os_thread_dpc {
/*
This table should be sorted by PCI device ID
*/
-static struct pci_device_id divas_pci_tbl[] = {
+static const struct pci_device_id divas_pci_tbl[] = {
/* Diva Server BRI-2M PCI 0xE010 */
{ PCI_VDEVICE(EICON, PCI_DEVICE_ID_EICON_MAESTRA),
CARDTYPE_MAESTRA_PCI },
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 05/10] isdn: mISDN: netjet: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (3 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 04/10] isdn: eicon: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 06/10] isdn: mISDN: hfcmulti: " Arvind Yadav
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
10941 1776 16 12733 31bd isdn/hardware/mISDN/netjet.o
File size After adding 'const':
text data bss dec hex filename
11005 1712 16 12733 31bd isdn/hardware/mISDN/netjet.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/mISDN/netjet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/netjet.c b/drivers/isdn/hardware/mISDN/netjet.c
index afde4ed..6a6d848 100644
--- a/drivers/isdn/hardware/mISDN/netjet.c
+++ b/drivers/isdn/hardware/mISDN/netjet.c
@@ -1137,7 +1137,7 @@ static void nj_remove(struct pci_dev *pdev)
/* We cannot select cards with PCI_SUB... IDs, since here are cards with
* SUB IDs set to PCI_ANY_ID, so we need to match all and reject
* known other cards which not work with this driver - see probe function */
-static struct pci_device_id nj_pci_ids[] = {
+static const struct pci_device_id nj_pci_ids[] = {
{ PCI_VENDOR_ID_TIGERJET, PCI_DEVICE_ID_TIGERJET_300,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ }
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 06/10] isdn: mISDN: hfcmulti: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (4 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 05/10] isdn: mISDN: netjet: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 07/10] isdn: mISDN: w6692: " Arvind Yadav
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
63450 1536 1492 66478 103ae isdn/hardware/mISDN/hfcmulti.o
File size After adding 'const':
text data bss dec hex filename
64698 288 1492 66478 103ae isdn/hardware/mISDN/hfcmulti.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index aea0c96..3cf07b8 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5348,7 +5348,7 @@ static const struct hm_map hfcm_map[] = {
#undef H
#define H(x) ((unsigned long)&hfcm_map[x])
-static struct pci_device_id hfmultipci_ids[] = {
+static const struct pci_device_id hfmultipci_ids[] = {
/* Cards with HFC-4S Chip */
{ PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC4S, PCI_VENDOR_ID_CCD,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 07/10] isdn: mISDN: w6692: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (5 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 06/10] isdn: mISDN: hfcmulti: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 08/10] isdn: mISDN: avmfritz: " Arvind Yadav
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
13959 4080 24 18063 468f isdn/hardware/mISDN/w6692.o
File size After adding 'const':
text data bss dec hex filename
14087 3952 24 18063 468f isdn/hardware/mISDN/w6692.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/mISDN/w6692.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/w6692.c b/drivers/isdn/hardware/mISDN/w6692.c
index 3052c83..d80072f 100644
--- a/drivers/isdn/hardware/mISDN/w6692.c
+++ b/drivers/isdn/hardware/mISDN/w6692.c
@@ -1398,7 +1398,7 @@ w6692_remove_pci(struct pci_dev *pdev)
pr_notice("%s: drvdata already removed\n", __func__);
}
-static struct pci_device_id w6692_ids[] = {
+static const struct pci_device_id w6692_ids[] = {
{ PCI_VENDOR_ID_DYNALINK, PCI_DEVICE_ID_DYNALINK_IS64PH,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, (ulong)&w6692_map[0]},
{ PCI_VENDOR_ID_WINBOND2, PCI_DEVICE_ID_WINBOND2_6692,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 08/10] isdn: mISDN: avmfritz: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (6 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 07/10] isdn: mISDN: w6692: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 09/10] isdn: mISDN: hfcpci: " Arvind Yadav
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
9963 1936 16 11915 2e8b isdn/hardware/mISDN/avmfritz.o
File size After adding 'const':
text data bss dec hex filename
10091 1808 16 11915 2e8b isdn/hardware/mISDN/avmfritz.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/mISDN/avmfritz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/avmfritz.c b/drivers/isdn/hardware/mISDN/avmfritz.c
index e3fa1cd..dce6632 100644
--- a/drivers/isdn/hardware/mISDN/avmfritz.c
+++ b/drivers/isdn/hardware/mISDN/avmfritz.c
@@ -1142,7 +1142,7 @@ fritz_remove_pci(struct pci_dev *pdev)
pr_info("%s: drvdata already removed\n", __func__);
}
-static struct pci_device_id fcpci_ids[] = {
+static const struct pci_device_id fcpci_ids[] = {
{ PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_A1, PCI_ANY_ID, PCI_ANY_ID,
0, 0, (unsigned long) "Fritz!Card PCI"},
{ PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_A1_V2, PCI_ANY_ID, PCI_ANY_ID,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 09/10] isdn: mISDN: hfcpci: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (7 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 08/10] isdn: mISDN: avmfritz: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-15 4:25 ` [PATCH 10/10] isdn: avm: c4: " Arvind Yadav
2017-07-16 4:26 ` [PATCH 00/10] Constify isdn pci_device_id's David Miller
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
21656 1024 96 22776 58f8 isdn/hardware/mISDN/hfcpci.o
File size After adding 'const':
text data bss dec hex filename
22424 256 96 22776 58f8 isdn/hardware/mISDN/hfcpci.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcpci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 5dc246d..d2e401a 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -2161,7 +2161,7 @@ static const struct _hfc_map hfc_map[] =
{},
};
-static struct pci_device_id hfc_ids[] =
+static const struct pci_device_id hfc_ids[] =
{
{ PCI_VDEVICE(CCD, PCI_DEVICE_ID_CCD_2BD0),
(unsigned long) &hfc_map[0] },
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 10/10] isdn: avm: c4: constify pci_device_id.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (8 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 09/10] isdn: mISDN: hfcpci: " Arvind Yadav
@ 2017-07-15 4:25 ` Arvind Yadav
2017-07-16 4:26 ` [PATCH 00/10] Constify isdn pci_device_id's David Miller
10 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-07-15 4:25 UTC (permalink / raw)
To: isdn, davem, dhowells, johannes.berg, mac, baoyou.xie
Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11803 544 1 12348 303c isdn/hardware/avm/c4.o
File size After adding 'const':
text data bss dec hex filename
11931 416 1 12348 303c isdn/hardware/avm/c4.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/avm/c4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/avm/c4.c b/drivers/isdn/hardware/avm/c4.c
index 40c7e2c..034caba 100644
--- a/drivers/isdn/hardware/avm/c4.c
+++ b/drivers/isdn/hardware/avm/c4.c
@@ -42,7 +42,7 @@ static char *revision = "$Revision: 1.1.2.2 $";
static bool suppress_pollack;
-static struct pci_device_id c4_pci_tbl[] = {
+static const struct pci_device_id c4_pci_tbl[] = {
{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C4, 0, 0, (unsigned long)4 },
{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C2, 0, 0, (unsigned long)2 },
{ } /* Terminating entry */
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 00/10] Constify isdn pci_device_id's.
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
` (9 preceding siblings ...)
2017-07-15 4:25 ` [PATCH 10/10] isdn: avm: c4: " Arvind Yadav
@ 2017-07-16 4:26 ` David Miller
10 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2017-07-16 4:26 UTC (permalink / raw)
To: arvind.yadav.cs
Cc: isdn, dhowells, johannes.berg, mac, baoyou.xie, netdev,
linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Sat, 15 Jul 2017 09:55:41 +0530
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
Series applied, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread