From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: isdn@linux-pingi.de, davem@davemloft.net, dhowells@redhat.com,
johannes.berg@intel.com, mac@melware.de, baoyou.xie@linaro.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 04/10] isdn: eicon: constify pci_device_id.
Date: Sat, 15 Jul 2017 09:55:45 +0530 [thread overview]
Message-ID: <1500092751-8291-5-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500092751-8291-1-git-send-email-arvind.yadav.cs@gmail.com>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
6224 655 8 6887 1ae7 isdn/hardware/eicon/divasmain.o
File size After adding 'const':
text data bss dec hex filename
6608 271 8 6887 1ae7 isdn/hardware/eicon/divasmain.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/eicon/divasmain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/eicon/divasmain.c b/drivers/isdn/hardware/eicon/divasmain.c
index 8b7ad4f..b2023e0 100644
--- a/drivers/isdn/hardware/eicon/divasmain.c
+++ b/drivers/isdn/hardware/eicon/divasmain.c
@@ -110,7 +110,7 @@ typedef struct _diva_os_thread_dpc {
/*
This table should be sorted by PCI device ID
*/
-static struct pci_device_id divas_pci_tbl[] = {
+static const struct pci_device_id divas_pci_tbl[] = {
/* Diva Server BRI-2M PCI 0xE010 */
{ PCI_VDEVICE(EICON, PCI_DEVICE_ID_EICON_MAESTRA),
CARDTYPE_MAESTRA_PCI },
--
2.7.4
next prev parent reply other threads:[~2017-07-15 4:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
2017-07-15 4:25 ` [PATCH 01/10] isdn: hisax: constify pci_device_id Arvind Yadav
2017-07-15 4:25 ` [PATCH 02/10] isdn: hisax: hfc4s8s_l1: " Arvind Yadav
2017-07-15 4:25 ` [PATCH 03/10] isdn: hisax: hisax_fcpcipnp: " Arvind Yadav
2017-07-15 4:25 ` Arvind Yadav [this message]
2017-07-15 4:25 ` [PATCH 05/10] isdn: mISDN: netjet: " Arvind Yadav
2017-07-15 4:25 ` [PATCH 06/10] isdn: mISDN: hfcmulti: " Arvind Yadav
2017-07-15 4:25 ` [PATCH 07/10] isdn: mISDN: w6692: " Arvind Yadav
2017-07-15 4:25 ` [PATCH 08/10] isdn: mISDN: avmfritz: " Arvind Yadav
2017-07-15 4:25 ` [PATCH 09/10] isdn: mISDN: hfcpci: " Arvind Yadav
2017-07-15 4:25 ` [PATCH 10/10] isdn: avm: c4: " Arvind Yadav
2017-07-16 4:26 ` [PATCH 00/10] Constify isdn pci_device_id's David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500092751-8291-5-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=baoyou.xie@linaro.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=isdn@linux-pingi.de \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).