From: Sean Wang <sean.wang@mediatek.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
John Crispin <blogic@openwrt.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<netdev@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()
Date: Wed, 19 Jul 2017 11:23:01 +0800 [thread overview]
Message-ID: <1500434581.19736.12.camel@mtkswgap22> (raw)
In-Reply-To: <20170718204805.GA30888@embeddedgus>
On Tue, 2017-07-18 at 15:48 -0500, Gustavo A. R. Silva wrote:
> Remove useless local variable _condition_ and the code related.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index b3d0c2e..7e95cf5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1027,7 +1027,6 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
> unsigned int done[MTK_MAX_DEVS];
> unsigned int bytes[MTK_MAX_DEVS];
> u32 cpu, dma;
> - static int condition;
> int total = 0, i;
>
> memset(done, 0, sizeof(done));
> @@ -1051,10 +1050,8 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
> mac = 1;
>
> skb = tx_buf->skb;
> - if (!skb) {
> - condition = 1;
> + if (!skb)
> break;
> - }
>
> if (skb != (struct sk_buff *)MTK_DMA_DUMMY_DESC) {
> bytes[mac] += skb->len;
Acked-by: Sean Wang <sean.wang@mediatek.com>
next prev parent reply other threads:[~2017-07-19 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 20:48 [PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx() Gustavo A. R. Silva
2017-07-19 3:23 ` Sean Wang [this message]
2017-07-19 23:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500434581.19736.12.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=blogic@openwrt.org \
--cc=gustavo@embeddedor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).