From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Wang <sean.wang@mediatek.com>
Subject: Re: [PATCH] net: ethernet: mediatek: remove useless code in
 mtk_poll_tx()
Date: Wed, 19 Jul 2017 11:23:01 +0800
Message-ID: <1500434581.19736.12.camel@mtkswgap22>
References: <20170718204805.GA30888@embeddedgus>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Felix Fietkau <nbd@openwrt.org>, John Crispin <blogic@openwrt.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        <netdev@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20170718204805.GA30888@embeddedgus>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Tue, 2017-07-18 at 15:48 -0500, Gustavo A. R. Silva wrote:
> Remove useless local variable _condition_ and the code related.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index b3d0c2e..7e95cf5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1027,7 +1027,6 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
>  	unsigned int done[MTK_MAX_DEVS];
>  	unsigned int bytes[MTK_MAX_DEVS];
>  	u32 cpu, dma;
> -	static int condition;
>  	int total = 0, i;
>  
>  	memset(done, 0, sizeof(done));
> @@ -1051,10 +1050,8 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget)
>  			mac = 1;
>  
>  		skb = tx_buf->skb;
> -		if (!skb) {
> -			condition = 1;
> +		if (!skb)
>  			break;
> -		}
>  
>  		if (skb != (struct sk_buff *)MTK_DMA_DUMMY_DESC) {
>  			bytes[mac] += skb->len;

Acked-by: Sean Wang <sean.wang@mediatek.com>