netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	Roopa Prabhu <roopa@cumulusnetworks.com>,
	David Ahern <dsahern@gmail.com>,
	Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info
Date: Fri, 28 Jul 2017 00:25:36 +0800	[thread overview]
Message-ID: <1501172736-13685-1-git-send-email-liuhangbin@gmail.com> (raw)
In-Reply-To: <1500562286-14312-1-git-send-email-liuhangbin@gmail.com>

After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib
result when requested"). When we get a prohibit ertry, we will return
-EACCES directly instead of dump route info.

Fix it by remove the rt->dst.error check.

Before fix:
\# ip -6 route add prohibit 2003::/64 dev eth1
\# ip -6 route get fibmatch 2003::1
RTNETLINK answers: Permission denied
\# ip -6 route add unreachable 2004::/64 dev eth1
\# ip -6 route get fibmatch 2004::1
RTNETLINK answers: No route to host

After fix:
\# ip -6 route add prohibit 2003::/64 dev eth1
\# ip -6 route get fibmatch 2003::1
prohibit 2003::/64 dev lo metric 1024 error -13 pref medium
\# ip -6 route add unreachable 2004::/64 dev eth1
\# ip -6 route get fibmatch 2004::1
unreachable 2004::/64 dev lo metric 1024 error -113 pref medium

Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 net/ipv6/route.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 4d30c96..8fc52de 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3637,12 +3637,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
 		dst = ip6_route_lookup(net, &fl6, 0);
 
 	rt = container_of(dst, struct rt6_info, dst);
-	if (rt->dst.error) {
-		err = rt->dst.error;
-		ip6_rt_put(rt);
-		goto errout;
-	}
-
 	if (rt == net->ipv6.ip6_null_entry) {
 		err = rt->dst.error;
 		ip6_rt_put(rt);
-- 
2.5.5

  parent reply	other threads:[~2017-07-27 16:26 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 14:51 [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry Hangbin Liu
2017-07-20 15:06 ` Hangbin Liu
2017-07-20 15:23   ` Hangbin Liu
2017-07-21 15:53     ` David Ahern
2017-07-21 18:42     ` Cong Wang
2017-07-21 21:53       ` Roopa Prabhu
2017-07-23  4:54         ` Roopa Prabhu
2017-07-24  3:09       ` Hangbin Liu
2017-07-24 19:57         ` Cong Wang
2017-07-25  0:08           ` Hangbin Liu
2017-07-25  3:28             ` David Ahern
2017-07-25  7:32               ` Hangbin Liu
2017-07-26 17:18                 ` David Ahern
2017-07-26 18:27                   ` Roopa Prabhu
2017-07-26 18:49                     ` David Ahern
2017-07-26 18:55                       ` Roopa Prabhu
2017-07-26 19:00                         ` David Ahern
2017-07-26 19:38                           ` Roopa Prabhu
2017-07-27 16:08                           ` Hangbin Liu
2017-07-28  4:56                       ` Cong Wang
2017-07-28 11:04                         ` Hangbin Liu
2017-07-28 15:10                         ` David Ahern
2017-07-28 17:13                           ` Roopa Prabhu
2017-07-28 17:39                             ` David Ahern
2017-07-28 19:52                               ` Roopa Prabhu
2017-07-29 14:41                                 ` David Ahern
2017-07-31 18:37                               ` Cong Wang
2017-07-31 18:40                                 ` David Ahern
2017-07-25 17:49             ` Cong Wang
2017-07-26  9:18               ` Hangbin Liu
2017-07-21  3:47 ` [PATCHv2 net] ipv6: should not return rt->dst.error if it is prohibit or blk hole entry Hangbin Liu
2017-07-21 15:29   ` kbuild test robot
2017-07-21 16:34   ` kbuild test robot
2017-07-23  4:55 ` [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry Roopa Prabhu
2017-07-24  2:28   ` Hangbin Liu
2017-07-26  9:20 ` [PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry Hangbin Liu
2017-07-26 17:09   ` David Ahern
2017-07-26 18:48     ` David Ahern
2017-07-27 13:48     ` Hangbin Liu
2017-07-27 16:25 ` Hangbin Liu [this message]
2017-07-27 18:03   ` [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info David Ahern
2017-07-28 17:23     ` David Ahern
2017-07-27 19:52   ` Roopa Prabhu
2017-07-31 23:22   ` David Miller
2017-07-31 23:34     ` David Ahern
2017-07-31 23:39       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501172736-13685-1-git-send-email-liuhangbin@gmail.com \
    --to=liuhangbin@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).