* [PATCH 3/4] net: sh_eth: constify platform_device_id
@ 2017-08-13 11:12 Arvind Yadav
2017-08-14 11:41 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-13 11:12 UTC (permalink / raw)
To: wg, mkl, madalin.bucur, davem, sergei.shtylyov, grygorii.strashko
Cc: linux-kernel, netdev, linux-renesas-soc
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index d2dc0a8..d2e88a3 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3402,7 +3402,7 @@ static const struct dev_pm_ops sh_eth_dev_pm_ops = {
#define SH_ETH_PM_OPS NULL
#endif
-static struct platform_device_id sh_eth_id_table[] = {
+static const struct platform_device_id sh_eth_id_table[] = {
{ "sh7619-ether", (kernel_ulong_t)&sh7619_data },
{ "sh771x-ether", (kernel_ulong_t)&sh771x_data },
{ "sh7724-ether", (kernel_ulong_t)&sh7724_data },
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] net: sh_eth: constify platform_device_id
2017-08-13 11:12 [PATCH 3/4] net: sh_eth: constify platform_device_id Arvind Yadav
@ 2017-08-14 11:41 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2017-08-14 11:41 UTC (permalink / raw)
To: Arvind Yadav, wg, mkl, madalin.bucur, davem, grygorii.strashko
Cc: linux-kernel, netdev, linux-renesas-soc
Hello!
On 08/13/2017 02:12 PM, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
though it seems too late as DaveM has taken the series...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-14 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-13 11:12 [PATCH 3/4] net: sh_eth: constify platform_device_id Arvind Yadav
2017-08-14 11:41 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).