* [PATCH] net/mlx4_core: make mlx4_profile const
@ 2017-08-23 12:47 Bhumika Goyal
2017-08-24 9:04 ` Tariq Toukan
2017-08-24 19:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Bhumika Goyal @ 2017-08-23 12:47 UTC (permalink / raw)
To: julia.lawall, tariqt, netdev, linux-rdma, linux-kernel; +Cc: Bhumika Goyal
Make these const as they are only used in a copy operation.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 541ce9e..43fb2eb 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -121,7 +121,7 @@
DRV_NAME ": Mellanox ConnectX core driver v"
DRV_VERSION "\n";
-static struct mlx4_profile default_profile = {
+static const struct mlx4_profile default_profile = {
.num_qp = 1 << 18,
.num_srq = 1 << 16,
.rdmarc_per_qp = 1 << 4,
@@ -131,7 +131,7 @@
.num_mtt = 1 << 20, /* It is really num mtt segements */
};
-static struct mlx4_profile low_mem_profile = {
+static const struct mlx4_profile low_mem_profile = {
.num_qp = 1 << 17,
.num_srq = 1 << 6,
.rdmarc_per_qp = 1 << 4,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx4_core: make mlx4_profile const
2017-08-23 12:47 [PATCH] net/mlx4_core: make mlx4_profile const Bhumika Goyal
@ 2017-08-24 9:04 ` Tariq Toukan
2017-08-24 19:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2017-08-24 9:04 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, tariqt, netdev, linux-rdma,
linux-kernel
On 23/08/2017 3:47 PM, Bhumika Goyal wrote:
> Make these const as they are only used in a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 541ce9e..43fb2eb 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -121,7 +121,7 @@
> DRV_NAME ": Mellanox ConnectX core driver v"
> DRV_VERSION "\n";
>
> -static struct mlx4_profile default_profile = {
> +static const struct mlx4_profile default_profile = {
> .num_qp = 1 << 18,
> .num_srq = 1 << 16,
> .rdmarc_per_qp = 1 << 4,
> @@ -131,7 +131,7 @@
> .num_mtt = 1 << 20, /* It is really num mtt segements */
> };
>
> -static struct mlx4_profile low_mem_profile = {
> +static const struct mlx4_profile low_mem_profile = {
> .num_qp = 1 << 17,
> .num_srq = 1 << 6,
> .rdmarc_per_qp = 1 << 4,
>
Thanks Bhumika.
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx4_core: make mlx4_profile const
2017-08-23 12:47 [PATCH] net/mlx4_core: make mlx4_profile const Bhumika Goyal
2017-08-24 9:04 ` Tariq Toukan
@ 2017-08-24 19:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-24 19:33 UTC (permalink / raw)
To: bhumirks; +Cc: julia.lawall, tariqt, netdev, linux-rdma, linux-kernel
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Wed, 23 Aug 2017 18:17:39 +0530
> Make these const as they are only used in a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-24 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-23 12:47 [PATCH] net/mlx4_core: make mlx4_profile const Bhumika Goyal
2017-08-24 9:04 ` Tariq Toukan
2017-08-24 19:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).