From: David Woodhouse <dwmw2@infradead.org>
To: Stephen Hemminger <stephen@networkplumber.org>,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com
Cc: devel@linuxdriverproject.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/7] netvsc: fix warnings reported by lockdep
Date: Thu, 24 Aug 2017 09:36:49 +0100 [thread overview]
Message-ID: <1503563809.7572.90.camel@infradead.org> (raw)
In-Reply-To: <20170728155947.10062-3-sthemmin@microsoft.com>
[-- Attachment #1.1: Type: text/plain, Size: 1019 bytes --]
On Fri, 2017-07-28 at 08:59 -0700, Stephen Hemminger wrote:
> This includes a bunch of fixups for issues reported by
> lockdep.
> * ethtool routines can assume RTNL
> * send is done with RCU lock (and BH disable)
> * avoid refetching internal device struct (netvsc)
> instead pass it as a parameter.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
The subject and the commit message are inconsistent — is this fixing
*warnings* (i.e. shut up a false positive), or is it fixing *issues*?
It looks like it's actually fixing issues, not just warnings?
It's really useful to get that right.
FWIW the reason I'm looking in my netdev@ folder for lockdep warning
fixes is because I was trying to confirm whether the commit message in
https://patchwork.kernel.org/patch/4372391/ is actually telling the
truth or not — in that case I think it *is* just a false positive being
shut up (and thus it's OK to say "fix warning"), not really fixing a
true issue.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2017-08-24 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 15:59 [PATCH net-next v3 0/7] netvsc: minor fixes and optimization Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 1/7] netvsc: fix return value for set_channels Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 2/7] netvsc: fix warnings reported by lockdep Stephen Hemminger
2017-08-24 8:36 ` David Woodhouse [this message]
2017-08-24 22:50 ` Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 3/7] netvsc: don't print pointer value in error message Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 4/7] netvsc: remove unnecessary indirection of page_buffer Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 5/7] netvsc: optimize receive completions Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 6/7] netvsc: fix error unwind on device setup failure Stephen Hemminger
2017-07-28 15:59 ` [PATCH net-next v3 7/7] netvsc: signal host if receive ring is emptied Stephen Hemminger
2017-07-29 22:26 ` [PATCH net-next v3 0/7] netvsc: minor fixes and optimization David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503563809.7572.90.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).