netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: edumazet@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
	jiri@resnulli.us, roopa@cumulusnetworks.com,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: [PATCH net 0/9] net/sched: init failure fixes
Date: Wed, 30 Aug 2017 12:48:56 +0300	[thread overview]
Message-ID: <1504086545-7777-1-git-send-email-nikolay@cumulusnetworks.com> (raw)

Hi all,
I went over all qdiscs' init, destroy and reset callbacks and found the
issues fixed in each patch. Mostly they are null pointer dereferences due
to uninitialized timer (qdisc watchdog) or double frees due to ->destroy
cleaning up a second time. There's more information in each patch.
I've tested these by either sending wrong attributes from user-spaces, no
attributes or by simulating memory alloc failure where applicable. Also
tried all of the qdiscs as a default qdisc.

Most of these bugs were present before commit 87b60cfacf9f, I've tried to
include proper fixes tags in each patch.

I haven't included individual patch acks in the set, I'd appreciate it if
you take another look and resend them.

Thanks,
 Nik

Nikolay Aleksandrov (9):
  sch_htb: fix crash on init failure
  sch_multiq: fix double free on init failure
  sch_hhf: fix null pointer dereference on init failure
  sch_hfsc: fix null pointer deref and double free on init failure
  sch_cbq: fix null pointer dereferences on init failure
  sch_fq_codel: avoid double free on init failure
  sch_netem: avoid null pointer deref on init failure
  sch_sfq: fix null pointer dereference on init failure
  sch_tbf: fix two null pointer dereferences on init failure

 net/sched/sch_cbq.c      | 10 +++++++---
 net/sched/sch_fq_codel.c |  4 +---
 net/sched/sch_hfsc.c     | 10 +++-------
 net/sched/sch_hhf.c      |  3 +++
 net/sched/sch_htb.c      |  5 +++--
 net/sched/sch_multiq.c   |  7 +------
 net/sched/sch_netem.c    |  4 ++--
 net/sched/sch_sfq.c      |  6 +++---
 net/sched/sch_tbf.c      |  5 +++--
 9 files changed, 26 insertions(+), 28 deletions(-)

-- 
2.1.4

             reply	other threads:[~2017-08-30  9:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  9:48 Nikolay Aleksandrov [this message]
2017-08-30  9:48 ` [PATCH net 1/9] sch_htb: fix crash on init failure Nikolay Aleksandrov
2017-08-30  9:48 ` [PATCH net 2/9] sch_multiq: fix double free " Nikolay Aleksandrov
2017-08-30  9:48 ` [PATCH net 3/9] sch_hhf: fix null pointer dereference " Nikolay Aleksandrov
2017-08-30  9:49 ` [PATCH net 4/9] sch_hfsc: fix null pointer deref and double free " Nikolay Aleksandrov
2017-08-30  9:49 ` [PATCH net 5/9] sch_cbq: fix null pointer dereferences " Nikolay Aleksandrov
2017-08-30  9:49 ` [PATCH net 6/9] sch_fq_codel: avoid double free " Nikolay Aleksandrov
2017-08-30 17:36   ` Cong Wang
2017-08-30 21:37     ` Nikolay Aleksandrov
2017-08-30  9:49 ` [PATCH net 7/9] sch_netem: avoid null pointer deref " Nikolay Aleksandrov
2017-08-30  9:49 ` [PATCH net 8/9] sch_sfq: fix null pointer dereference " Nikolay Aleksandrov
2017-08-30  9:49 ` [PATCH net 9/9] sch_tbf: fix two null pointer dereferences " Nikolay Aleksandrov
2017-08-30 17:37   ` Cong Wang
2017-08-30 21:39     ` Nikolay Aleksandrov
2017-08-30 12:15 ` [PATCH net 0/9] net/sched: init failure fixes Jamal Hadi Salim
2017-08-30 21:35   ` Nikolay Aleksandrov
2017-08-30 22:26   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504086545-7777-1-git-send-email-nikolay@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).