netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: netdev@vger.kernel.org, daniel@iogearbox.net, ast@kernel.org
Cc: David Ahern <dsahern@gmail.com>
Subject: [PATCH v3 net-next 7/7] samples/bpf: Update cgroup socket examples to use uid gid helper
Date: Thu, 31 Aug 2017 15:05:50 -0700	[thread overview]
Message-ID: <1504217150-16151-8-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1504217150-16151-1-git-send-email-dsahern@gmail.com>

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 samples/bpf/sock_flags_kern.c |  5 +++++
 samples/bpf/test_cgrp2_sock.c | 12 +++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/samples/bpf/sock_flags_kern.c b/samples/bpf/sock_flags_kern.c
index 533dd11a6baa..05dcdf8a4baa 100644
--- a/samples/bpf/sock_flags_kern.c
+++ b/samples/bpf/sock_flags_kern.c
@@ -9,8 +9,13 @@ SEC("cgroup/sock1")
 int bpf_prog1(struct bpf_sock *sk)
 {
 	char fmt[] = "socket: family %d type %d protocol %d\n";
+	char fmt2[] = "socket: uid %u gid %u\n";
+	__u64 gid_uid = bpf_get_current_uid_gid();
+	__u32 uid = gid_uid & 0xffffffff;
+	__u32 gid = gid_uid >> 32;
 
 	bpf_trace_printk(fmt, sizeof(fmt), sk->family, sk->type, sk->protocol);
+	bpf_trace_printk(fmt2, sizeof(fmt2), uid, gid);
 
 	/* block PF_INET6, SOCK_RAW, IPPROTO_ICMPV6 sockets
 	 * ie., make ping6 fail
diff --git a/samples/bpf/test_cgrp2_sock.c b/samples/bpf/test_cgrp2_sock.c
index 5a688837720c..e79594dd629b 100644
--- a/samples/bpf/test_cgrp2_sock.c
+++ b/samples/bpf/test_cgrp2_sock.c
@@ -46,8 +46,18 @@ static int prog_load(__u32 idx, __u32 mark, __u32 prio)
 
 	/* set mark on socket */
 	struct bpf_insn prog_mark[] = {
-		BPF_MOV64_REG(BPF_REG_1, BPF_REG_6),
+		/* get uid of process */
+		BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0,
+			     BPF_FUNC_get_current_uid_gid),
+		BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xffffffff),
+
+		/* if uid is 0, use given mark, else use the uid as the mark */
+		BPF_MOV64_REG(BPF_REG_3, BPF_REG_0),
+		BPF_JMP_IMM(BPF_JNE, BPF_REG_0, 0, 1),
 		BPF_MOV64_IMM(BPF_REG_3, mark),
+
+		/* set the mark on the new socket */
+		BPF_MOV64_REG(BPF_REG_1, BPF_REG_6),
 		BPF_MOV64_IMM(BPF_REG_2, offsetof(struct bpf_sock, mark)),
 		BPF_STX_MEM(BPF_W, BPF_REG_1, BPF_REG_3, offsetof(struct bpf_sock, mark)),
 	};
-- 
2.1.4

  parent reply	other threads:[~2017-08-31 22:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 22:05 [PATCH v3 net-next 0/7] bpf: Add option to set mark and priority in cgroup sock programs David Ahern
2017-08-31 22:05 ` [PATCH v3 net-next 1/7] bpf: Add mark and priority to sock options that can be set David Ahern
2017-08-31 22:21   ` Daniel Borkmann
2017-08-31 22:05 ` [PATCH v3 net-next 2/7] bpf: Allow cgroup sock filters to use get_current_uid_gid helper David Ahern
2017-08-31 22:22   ` Daniel Borkmann
2017-08-31 22:05 ` [PATCH v3 net-next 3/7] samples/bpf: Update sock test to allow setting mark and priority David Ahern
2017-09-01  1:38   ` Alexei Starovoitov
2017-08-31 22:05 ` [PATCH v3 net-next 4/7] samples/bpf: Add detach option to test_cgrp2_sock David Ahern
2017-09-01  1:39   ` Alexei Starovoitov
2017-08-31 22:05 ` [PATCH v3 net-next 5/7] samples/bpf: Add option to dump socket settings David Ahern
2017-09-01  1:39   ` Alexei Starovoitov
2017-08-31 22:05 ` [PATCH v3 net-next 6/7] samples/bpf: Update cgrp2 socket tests David Ahern
2017-09-01  1:40   ` Alexei Starovoitov
2017-08-31 22:05 ` David Ahern [this message]
2017-09-01  1:41   ` [PATCH v3 net-next 7/7] samples/bpf: Update cgroup socket examples to use uid gid helper Alexei Starovoitov
2017-09-01  5:06 ` [PATCH v3 net-next 0/7] bpf: Add option to set mark and priority in cgroup sock programs David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504217150-16151-8-git-send-email-dsahern@gmail.com \
    --to=dsahern@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).