From: Jesper Dangaard Brouer <brouer@redhat.com>
To: netdev@vger.kernel.org
Cc: mkubecek@suse.cz, Florian Westphal <fw@strlen.de>,
liujian56@huawei.com, Jesper Dangaard Brouer <brouer@redhat.com>
Subject: [PATCH net 0/2] net: revert lib/percpu_counter API for fragmentation mem accounting
Date: Fri, 01 Sep 2017 11:26:03 +0200 [thread overview]
Message-ID: <150425790711.22227.12264977619066874632.stgit@firesoul> (raw)
There is a bug in fragmentation codes use of the percpu_counter API,
that can cause issues on systems with many CPUs, above 24 CPUs.
After much consideration and different attempts at solving the API
usage. The conclusion is to revert to the simple atomic_t API instead.
The ratio between batch size and threshold size make it a bad use-case
for the lib/percpu_counter API. As using the correct API calls will
unfortunately cause systems with many CPUs to always execute an
expensive sum across all CPUs. Plus the added complexity is not worth it.
---
Jesper Dangaard Brouer (2):
Revert "net: use lib/percpu_counter API for fragmentation mem accounting"
Revert "net: fix percpu memory leaks"
include/net/inet_frag.h | 35 ++++++++-----------------------
net/ieee802154/6lowpan/reassembly.c | 11 +++-------
net/ipv4/inet_fragment.c | 4 +---
net/ipv4/ip_fragment.c | 12 +++--------
net/ipv6/netfilter/nf_conntrack_reasm.c | 12 +++--------
net/ipv6/reassembly.c | 12 +++--------
6 files changed, 22 insertions(+), 64 deletions(-)
next reply other threads:[~2017-09-01 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 9:26 Jesper Dangaard Brouer [this message]
2017-09-01 9:26 ` [PATCH net 1/2] Revert "net: use lib/percpu_counter API for fragmentation mem accounting" Jesper Dangaard Brouer
2017-09-01 9:30 ` Florian Westphal
2017-09-01 9:26 ` [PATCH net 2/2] Revert "net: fix percpu memory leaks" Jesper Dangaard Brouer
2017-09-03 18:01 ` [PATCH net 0/2] net: revert lib/percpu_counter API for fragmentation mem accounting David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150425790711.22227.12264977619066874632.stgit@firesoul \
--to=brouer@redhat.com \
--cc=fw@strlen.de \
--cc=liujian56@huawei.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox