* [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access
@ 2017-09-01 15:18 David Ahern
2017-09-01 15:53 ` Daniel Borkmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Ahern @ 2017-09-01 15:18 UTC (permalink / raw)
To: netdev, daniel; +Cc: David Ahern
Make sock_filter_is_valid_access consistent with other is_valid_access
helpers.
Requested-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/core/filter.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 9dad3e7e2e10..f9add024d92f 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -3468,9 +3468,7 @@ static bool sock_filter_is_valid_access(int off, int size,
if (type == BPF_WRITE) {
switch (off) {
case offsetof(struct bpf_sock, bound_dev_if):
- break;
case offsetof(struct bpf_sock, mark):
- break;
case offsetof(struct bpf_sock, priority):
break;
default:
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access
2017-09-01 15:18 [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access David Ahern
@ 2017-09-01 15:53 ` Daniel Borkmann
2017-09-01 16:35 ` Alexei Starovoitov
2017-09-01 17:37 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2017-09-01 15:53 UTC (permalink / raw)
To: David Ahern, netdev
On 09/01/2017 05:18 PM, David Ahern wrote:
> Make sock_filter_is_valid_access consistent with other is_valid_access
> helpers.
>
> Requested-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Thanks for following up,
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access
2017-09-01 15:18 [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access David Ahern
2017-09-01 15:53 ` Daniel Borkmann
@ 2017-09-01 16:35 ` Alexei Starovoitov
2017-09-01 17:37 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2017-09-01 16:35 UTC (permalink / raw)
To: David Ahern; +Cc: netdev, daniel
On Fri, Sep 01, 2017 at 08:18:07AM -0700, David Ahern wrote:
> Make sock_filter_is_valid_access consistent with other is_valid_access
> helpers.
>
> Requested-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access
2017-09-01 15:18 [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access David Ahern
2017-09-01 15:53 ` Daniel Borkmann
2017-09-01 16:35 ` Alexei Starovoitov
@ 2017-09-01 17:37 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-09-01 17:37 UTC (permalink / raw)
To: dsahern; +Cc: netdev, daniel
From: David Ahern <dsahern@gmail.com>
Date: Fri, 1 Sep 2017 08:18:07 -0700
> Make sock_filter_is_valid_access consistent with other is_valid_access
> helpers.
>
> Requested-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-01 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 15:18 [PATCH net-next] bpf: Collapse offset checks in sock_filter_is_valid_access David Ahern
2017-09-01 15:53 ` Daniel Borkmann
2017-09-01 16:35 ` Alexei Starovoitov
2017-09-01 17:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).