From: Johannes Berg <johannes@sipsolutions.net>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Matteo Croce <mcroce@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: hung task in mac80211
Date: Wed, 06 Sep 2017 15:30:10 +0200 [thread overview]
Message-ID: <1504704610.23905.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20170906152709.673f230d@elisabeth>
On Wed, 2017-09-06 at 15:27 +0200, Stefano Brivio wrote:
>
> Yes, that was based on the assumption that the initial part of
> __ieee80211_start_rx_ba_session() can't really affect the AMPDU
> state-machine in any way.
That's not really the point, if that changes that function would have
to move the locking around, and nothing else.
The point is more that code in ieee80211_ba_session_work() could assume
the lock is held across the entire loop, since that's the way it's
written and looks like even with your patch.
So for example replacing the loop of tid = 0..NUM_TIDS-1 with a
list_for_each_entry() would already be unsafe with the dropping if the
list were to require the mutex for locking.
johannes
next prev parent reply other threads:[~2017-09-06 13:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 11:57 hung task in mac80211 Matteo Croce
[not found] ` <CAGnkfhwi9MmtLneeU23iWEGLj9cb1ODb3KzzOqTDvA6nNVsugg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-06 12:28 ` Christian Lamparter
2017-09-06 12:40 ` Stefano Brivio
2017-09-06 12:48 ` Johannes Berg
2017-09-06 13:03 ` Johannes Berg
[not found] ` <1504702990.13457.19.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-09-06 13:08 ` Sebastian Gottschall
2017-09-06 13:19 ` Stefano Brivio
2017-09-06 13:21 ` Johannes Berg
2017-09-06 13:27 ` Stefano Brivio
2017-09-06 13:30 ` Johannes Berg [this message]
2017-09-06 13:40 ` Stefano Brivio
2017-09-06 13:07 ` Matteo Croce
2017-09-06 12:58 ` Johannes Berg
2017-09-06 14:27 ` Stefano Brivio
2017-09-06 14:30 ` Johannes Berg
2017-09-06 15:04 ` Matteo Croce
2017-09-06 15:11 ` Johannes Berg
2017-09-06 15:45 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504704610.23905.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).