From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Michal Kubecek <mkubecek@suse.cz>, Phil Sutter <phil@nwl.cc>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCH iproute2 0/2] malloc correct buff at run time
Date: Fri, 8 Sep 2017 18:14:55 +0800 [thread overview]
Message-ID: <1504865697-27274-1-git-send-email-liuhangbin@gmail.com> (raw)
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") and
460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"), we
extend the buffer size to avoid truncated message with large numbers of
VFs. But just as Michal said, this is not future-proof since the NIC
number is increasing. We have customer even has 220+ VFs now.
This is not make sense to hard code the buffer and increase it all the time.
So let's just malloc the correct buff size at run time.
I'm not sure what init size would be suitable, so I keep use the original
size. I have tried with a small size like 1024, and it also works.
I tested with most ip cmds and all looks good.
Hangbin Liu (2):
lib/libnetlink: re malloc buff if size is not enough
lib/libnetlink: update rtnl_talk to support malloc buff at run time
bridge/fdb.c | 2 +-
bridge/link.c | 2 +-
bridge/mdb.c | 2 +-
bridge/vlan.c | 2 +-
genl/ctrl.c | 14 +++---
include/libnetlink.h | 6 +--
ip/ipaddress.c | 5 ++-
ip/ipaddrlabel.c | 4 +-
ip/ipfou.c | 4 +-
ip/ipila.c | 4 +-
ip/ipl2tp.c | 8 ++--
ip/iplink.c | 28 +++++-------
ip/iplink_vrf.c | 24 ++++-------
ip/ipmacsec.c | 2 +-
ip/ipneigh.c | 2 +-
ip/ipnetns.c | 13 +++---
ip/ipntable.c | 2 +-
ip/iproute.c | 20 +++++----
ip/iprule.c | 7 +--
ip/ipseg6.c | 7 +--
ip/iptoken.c | 2 +-
ip/link_gre.c | 7 +--
ip/link_gre6.c | 7 +--
ip/link_ip6tnl.c | 7 +--
ip/link_iptnl.c | 7 +--
ip/link_vti.c | 7 +--
ip/link_vti6.c | 7 +--
ip/tcp_metrics.c | 7 +--
ip/xfrm_policy.c | 22 +++++-----
ip/xfrm_state.c | 25 ++++++-----
lib/libgenl.c | 5 ++-
lib/libnetlink.c | 118 ++++++++++++++++++++++++++++++++-------------------
misc/ss.c | 2 +-
tc/m_action.c | 9 ++--
tc/tc_class.c | 2 +-
tc/tc_filter.c | 7 +--
tc/tc_qdisc.c | 2 +-
37 files changed, 217 insertions(+), 184 deletions(-)
--
2.5.5
next reply other threads:[~2017-09-08 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 10:14 Hangbin Liu [this message]
2017-09-08 10:14 ` [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough Hangbin Liu
2017-09-08 11:02 ` Phil Sutter
2017-09-08 12:32 ` Michal Kubecek
2017-09-08 14:01 ` Hangbin Liu
2017-09-08 14:51 ` Phil Sutter
2017-09-11 7:19 ` Hangbin Liu
2017-09-12 8:47 ` Michal Kubecek
2017-09-12 9:09 ` Michal Kubecek
2017-09-13 9:26 ` Hangbin Liu
2017-09-08 10:14 ` [PATCH iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time Hangbin Liu
2017-09-08 11:06 ` Phil Sutter
2017-09-08 13:26 ` Hangbin Liu
2017-09-08 12:03 ` [PATCH iproute2 0/2] malloc correct " Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504865697-27274-1-git-send-email-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).