From: David Woodhouse <dwmw2@infradead.org>
To: David Miller <davem@davemloft.net>, eduval@amazon.com
Cc: vallish@amazon.com, shuah@kernel.org, richardcochran@gmail.com,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, anchalag@amazon.com,
dwmw@amazon.com
Subject: Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket
Date: Fri, 08 Sep 2017 18:23:22 +0100 [thread overview]
Message-ID: <1504891402.32080.5.camel@infradead.org> (raw)
In-Reply-To: <20170908.101657.2131282706895004921.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]
On Fri, 2017-09-08 at 10:16 -0700, David Miller wrote:
> From: Eduardo Valentin <eduval@amazon.com>
> Date: Fri, 8 Sep 2017 10:04:09 -0700
>
> >
> > However, this is a clear, the system call, from the net subsystem,
> > has changed in behavior across kernel versions. From application /
> > userspace perspective, changing the system call without clear
> > documentation or deprecation path, to me, looks like breaking
> > userspace, isn't it?
>
> Where is the chapter and verse of the system call documentation that
> guaranteed this level of timer granularity for you?
>
> Or were you simply relying upon implementation dependent behavior?
> I can't see anything which ever guarateed the granularity of timers
> to the extent upon which you were relying.
>
> And most importantly, letting the kernel have flexibility in this area
> is absolutely essential for various forms of optimizations and power
> savings.
The rule we normally use, typically enforced very shoutily by Linus, is
that *however* stupid userspace was to rely on something, if they *do*
rely on it then we shouldn't change it.
I don't know that anyone's ever tried saying "show me the chapter and
verse of the documentation" to Linus when he's in full rant mode, as he
tends to get in such discussions. You could try it, I suppose.
I don't think 'HZ==100' was documented per se either, was it? Perhaps
we *could* change that, after all? :)
(Not that I've actually looked at the patch or the userspace in
question yet, mind you. Just commenting on the absurdity of the
response.)
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
next prev parent reply other threads:[~2017-09-08 17:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 0:10 [PATCH v2 0/2] enable hires timer to timeout datagram socket Vallish Vaidyeshwara
2017-08-23 0:10 ` [PATCH v2 1/2] net: enable high resolution timer mode to timeout datagram sockets Vallish Vaidyeshwara
2017-08-23 0:10 ` [PATCH v2 2/2] selftests/net: add test to verify datagram socket timeout Vallish Vaidyeshwara
2017-08-23 4:30 ` [PATCH v2 0/2] enable hires timer to timeout datagram socket David Miller
2017-08-27 20:47 ` Vallish Vaidyeshwara
2017-08-29 11:16 ` David Laight
2017-09-08 17:04 ` Eduardo Valentin
2017-09-08 17:16 ` David Miller
2017-09-08 17:23 ` David Woodhouse [this message]
2017-09-08 17:26 ` David Miller
2017-09-08 18:55 ` Eduardo Valentin
2017-09-08 19:11 ` Eric Dumazet
2017-09-16 9:47 ` Thomas Gleixner
2017-09-20 22:48 ` Vallish Vaidyeshwara
2017-09-25 20:42 ` Thomas Gleixner
2017-09-08 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504891402.32080.5.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=anchalag@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=eduval@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=shuah@kernel.org \
--cc=vallish@amazon.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).