From mboxrd@z Thu Jan 1 00:00:00 1970 From: rosenp@gmail.com Subject: Re: [PATCH] bgmac: Remove all offloading features, including GRO. Date: Fri, 15 Sep 2017 17:10:38 -0700 Message-ID: <1505520638.8507.2.camel@gmail.com> References: <20170915222218.6613-1-rosenp@gmail.com> <252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com> <1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name To: Eric Dumazet , Florian Fainelli Return-path: Received: from mail-pg0-f52.google.com ([74.125.83.52]:56562 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdIPAKk (ORCPT ); Fri, 15 Sep 2017 20:10:40 -0400 Received: by mail-pg0-f52.google.com with SMTP id 7so2338842pgd.13 for ; Fri, 15 Sep 2017 17:10:40 -0700 (PDT) In-Reply-To: <1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: Ok fair enough. Will only disable GRO in the driver. Tests were done using "ethtool -K eth0 gro off" and on. On Fri, 2017-09-15 at 17:03 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote: > > On September 15, 2017 3:22:18 PM PDT, Rosen Penev > > > > wrote: > > > On a linksys E1200v1 (actually a crossflashed E1000v2), the > > > > offloading > > > features give no measurable benefit to speed or latency. > > > Furthermore, > > > disabling GRO actually improves iperf performance by a whoppimg > > > > 3mbps. > > > > Do you have a way to generate gigabit tests and see what results > > you > > are getting? We probably are not going to see a 30% improvement > > just > > by extrapolation. > > > > +1 > > It seems silly to remove NETIF_F_SG | NETIF_F_IP_CSUM | > NETIF_F_IPV6_CSUM from dev->features, yet leave the dead-code in the > driver to handle these features. > > And of course GRO was not removed, meaning the bench results were non > conclusive. > > >