Netdev List
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: fugang.duan@nxp.com, netdev@vger.kernel.org, davem@davemloft.net
Cc: fabio.estevam@nxp.com, lznuaa@gmail.com,
	Troy Kisky <troy.kisky@boundarydevices.com>
Subject: [PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS_TIMER
Date: Tue, 19 Sep 2017 17:33:08 -0700	[thread overview]
Message-ID: <1505867589-11784-2-git-send-email-troy.kisky@boundarydevices.com> (raw)
In-Reply-To: <1505867589-11784-1-git-send-email-troy.kisky@boundarydevices.com>

FEC_ENET_TS_TIMER is not checked in the interrupt routine
so there is no need to enable it.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>

---
v4: Added Acked-by

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
 drivers/net/ethernet/freescale/fec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
index 38c7b21..ede1876 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -374,8 +374,8 @@ struct bufdesc_ex {
 #define FEC_ENET_TS_AVAIL       ((uint)0x00010000)
 #define FEC_ENET_TS_TIMER       ((uint)0x00008000)
 
-#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII | FEC_ENET_TS_TIMER)
-#define FEC_NAPI_IMASK	(FEC_ENET_MII | FEC_ENET_TS_TIMER)
+#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII)
+#define FEC_NAPI_IMASK	FEC_ENET_MII
 #define FEC_RX_DISABLED_IMASK (FEC_DEFAULT_IMASK & (~FEC_ENET_RXF))
 
 /* ENET interrupt coalescing macro define */
-- 
2.7.4

  reply	other threads:[~2017-09-20  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  0:33 [PATCH v4 1/3] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set Troy Kisky
2017-09-20  0:33 ` Troy Kisky [this message]
2017-09-20  2:14   ` [PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS_TIMER Andy Duan
2017-09-20 22:47   ` David Miller
2017-09-20  0:33 ` [PATCH v4 3/3] net: fec: return IRQ_HANDLED if fec_ptp_check_pps_event handled it Troy Kisky
2017-09-20 22:47   ` David Miller
2017-09-20 22:47 ` [PATCH v4 1/3] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505867589-11784-2-git-send-email-troy.kisky@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=davem@davemloft.net \
    --cc=fabio.estevam@nxp.com \
    --cc=fugang.duan@nxp.com \
    --cc=lznuaa@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox