From: Joe Perches <joe@perches.com>
To: gfree.wind@vip.163.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next ] net: Remove useless function skb_header_release
Date: Wed, 20 Sep 2017 21:49:10 -0700 [thread overview]
Message-ID: <1505969350.12311.20.camel@perches.com> (raw)
In-Reply-To: <1505968771-92232-1-git-send-email-gfree.wind@vip.163.com>
On Thu, 2017-09-21 at 12:39 +0800, gfree.wind@vip.163.com wrote:
> From: Gao Feng <gfree.wind@vip.163.com>
>
> There is no one which would invokes the function skb_header_release.
> So just remove it now.
This in incomplete.
There are other references to this function.
$ git grep -w skb_header_release
drivers/net/usb/asix_common.c: * TCP packets for example are cloned, but skb_header_release()
include/linux/skbuff.h: * skb_header_release - release reference to header
include/linux/skbuff.h:static inline void skb_header_release(struct sk_buff *skb)
include/linux/skbuff.h: * Variant of skb_header_release() assuming skb is private to caller.
net/batman-adv/soft-interface.c: * data using skb_header_release in our skbs to allow skb_cow_header to
next prev parent reply other threads:[~2017-09-21 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 4:39 [PATCH net-next ] net: Remove useless function skb_header_release gfree.wind
2017-09-21 4:49 ` Joe Perches [this message]
2017-09-21 5:07 ` Gao Feng
2017-09-21 22:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505969350.12311.20.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gfree.wind@vip.163.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox