* [PATCH 1/1] net: wan : hdlc: use setup_timer() helper
@ 2017-09-21 12:47 Allen Pais
2017-09-21 22:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Allen Pais @ 2017-09-21 12:47 UTC (permalink / raw)
To: linux-kernel; +Cc: khc, netdev, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/net/wan/hdlc_fr.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index 78596e4..425a47f 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -1003,11 +1003,10 @@ static void fr_start(struct net_device *dev)
state(hdlc)->n391cnt = 0;
state(hdlc)->txseq = state(hdlc)->rxseq = 0;
- init_timer(&state(hdlc)->timer);
+ setup_timer(&state(hdlc)->timer, fr_timer,
+ (unsigned long)dev);
/* First poll after 1 s */
state(hdlc)->timer.expires = jiffies + HZ;
- state(hdlc)->timer.function = fr_timer;
- state(hdlc)->timer.data = (unsigned long)dev;
add_timer(&state(hdlc)->timer);
} else
fr_set_link_state(1, dev);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] net: wan : hdlc: use setup_timer() helper
2017-09-21 12:47 [PATCH 1/1] net: wan : hdlc: use setup_timer() helper Allen Pais
@ 2017-09-21 22:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-21 22:49 UTC (permalink / raw)
To: allen.lkml; +Cc: linux-kernel, khc, netdev
From: Allen Pais <allen.lkml@gmail.com>
Date: Thu, 21 Sep 2017 18:17:55 +0530
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-21 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-21 12:47 [PATCH 1/1] net: wan : hdlc: use setup_timer() helper Allen Pais
2017-09-21 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).