* [PATCH 1/1] net: usb: catc: use setup_timer() helper
@ 2017-09-21 12:54 Allen Pais
2017-09-21 22:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Allen Pais @ 2017-09-21 12:54 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-usb, netdev, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/net/usb/catc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index dbc9031..aeb62e1 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -805,9 +805,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
spin_lock_init(&catc->tx_lock);
spin_lock_init(&catc->ctrl_lock);
- init_timer(&catc->timer);
- catc->timer.data = (long) catc;
- catc->timer.function = catc_stats_timer;
+ setup_timer(&catc->timer, catc_stats_timer, (long)catc);
catc->ctrl_urb = usb_alloc_urb(0, GFP_KERNEL);
catc->tx_urb = usb_alloc_urb(0, GFP_KERNEL);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] net: usb: catc: use setup_timer() helper
2017-09-21 12:54 [PATCH 1/1] net: usb: catc: use setup_timer() helper Allen Pais
@ 2017-09-21 22:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-21 22:49 UTC (permalink / raw)
To: allen.lkml; +Cc: linux-kernel, linux-usb, netdev
From: Allen Pais <allen.lkml@gmail.com>
Date: Thu, 21 Sep 2017 18:24:15 +0530
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-21 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-21 12:54 [PATCH 1/1] net: usb: catc: use setup_timer() helper Allen Pais
2017-09-21 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).