From: Allen Pais <allen.lkml@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,
dmitry.tarnyagin@lockless.no, wg@grandegger.com,
mkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,
pcnet32@frontier.com, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,
ajk@comnets.uni-bremen.de, jes@trained-monkey.org,
romieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,
davem@davemloft.net, linux-can@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
Allen Pais <allen.lkml@gmail.com>
Subject: [PATCH 54/64] drivers: net: hdlc_ppp: use setup_timer() helper.
Date: Thu, 21 Sep 2017 22:35:15 +0530 [thread overview]
Message-ID: <1506013525-29291-55-git-send-email-allen.lkml@gmail.com> (raw)
In-Reply-To: <1506013525-29291-1-git-send-email-allen.lkml@gmail.com>
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/net/wan/hdlc_ppp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index 0d2e00e..c7721c7 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -610,9 +610,7 @@ static void ppp_start(struct net_device *dev)
for (i = 0; i < IDX_COUNT; i++) {
struct proto *proto = &ppp->protos[i];
proto->dev = dev;
- init_timer(&proto->timer);
- proto->timer.function = ppp_timer;
- proto->timer.data = (unsigned long)proto;
+ setup_timer(&proto->timer, ppp_timer, (unsigned long)proto);
proto->state = CLOSED;
}
ppp->protos[IDX_LCP].pid = PID_LCP;
--
2.7.4
next prev parent reply other threads:[~2017-09-21 17:05 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 17:04 [PATCH 00/64] use setup_timer() helper function Allen Pais
2017-09-21 17:04 ` [PATCH 01/64] drivers: net: de4x: use setup_timer() helper Allen Pais
2017-09-21 17:04 ` [PATCH 02/64] drivers: net: b44: " Allen Pais
2017-09-21 17:04 ` [PATCH 03/64] drivers: net: pcnet32: " Allen Pais
2017-09-21 17:04 ` [PATCH 04/64] drivers: net: brcm80211: " Allen Pais
2017-09-21 17:04 ` [PATCH 05/64] drivers : net: niu: " Allen Pais
2017-09-21 17:04 ` [PATCH 06/64] drivers: net: bcm63xx: " Allen Pais
2017-09-21 17:04 ` [PATCH 07/64] drivers: net: declance: " Allen Pais
2017-09-21 17:04 ` [PATCH 08/64] drivers: net: am79c961: " Allen Pais
2017-09-21 17:04 ` [PATCH 09/64] drivers: net: et131x: " Allen Pais
2017-09-21 17:04 ` [PATCH 10/64] drivers: net: appletalk: cops: " Allen Pais
2017-09-21 17:04 ` [PATCH 11/64] drivers: net: rsi_91x: " Allen Pais
2017-09-21 17:04 ` [PATCH 12/64] drivers: net: atp: " Allen Pais
2017-09-21 17:04 ` [PATCH 13/64] drivers: net: ns83820: " Allen Pais
2017-09-21 17:04 ` [PATCH 14/64] drivers: net: ixgb: " Allen Pais
2017-09-21 17:04 ` [PATCH 15/64] drivers: net: sundance: " Allen Pais
2017-09-21 17:04 ` [PATCH 16/64] drivers: net: tg3: " Allen Pais
2017-09-21 17:04 ` [PATCH 17/64] drivers: net: sdla: " Allen Pais
2017-09-21 17:04 ` [PATCH 18/64] drivers: net: cisco_hdlc: " Allen Pais
2017-09-21 17:04 ` [PATCH 19/64] drivers: net: slip: " Allen Pais
2017-09-21 17:04 ` [PATCH 20/64] drivers: net: spider_net: " Allen Pais
2017-09-21 17:04 ` [PATCH 21/64] drivers: net: sun: cassini: " Allen Pais
2017-09-21 17:04 ` [PATCH 22/64] drivers: net: natsemi: " Allen Pais
2017-09-21 17:04 ` [PATCH 23/64] drivers: net: winbond-840: " Allen Pais
2017-09-21 17:04 ` [PATCH 24/64] drivers: net: enic: " Allen Pais
2017-09-21 17:04 ` [PATCH 25/64] drivers: net: bnx2: " Allen Pais
2017-09-21 17:04 ` [PATCH 26/64] drivers: net: xen-netback: " Allen Pais
2017-09-21 17:04 ` [PATCH 27/64] drivers: net: atmel: " Allen Pais
2017-09-21 17:04 ` [PATCH 28/64] drivers: net: hippi: " Allen Pais
2017-09-21 17:04 ` [PATCH 29/64] drivers: net: smsc: " Allen Pais
2017-09-21 17:04 ` [PATCH 30/64] drivers: net: qlogic: " Allen Pais
2017-09-21 17:04 ` [PATCH 31/64] drivers: net: e1000e: " Allen Pais
2017-09-21 17:04 ` [PATCH 32/64] drivers: net: amd: " Allen Pais
2017-09-21 17:04 ` [PATCH 33/64] drivers: net: amd8111e: " Allen Pais
2017-09-21 17:04 ` [PATCH 34/64] drivers: net: eql: " Allen Pais
2017-09-21 17:04 ` [PATCH 35/64] drivers: net: can: usb: " Allen Pais
2017-09-21 17:04 ` [PATCH 36/64] drivers: net: can: " Allen Pais
2017-09-21 17:04 ` [PATCH 37/64] drivers: net: arcnet: " Allen Pais
2017-09-21 17:04 ` [PATCH 38/64] drivers: net: ath6kl: " Allen Pais
2017-09-21 17:05 ` [PATCH 39/64] drivers: net: sun: " Allen Pais
2017-09-21 17:05 ` [PATCH 40/64] drivers: net: sis900: " Allen Pais
2017-09-21 17:05 ` [PATCH 41/64] drivers: net: packetengines: " Allen Pais
2017-09-21 17:05 ` [PATCH 42/64] drivers: net: mlx5: " Allen Pais
2017-09-21 17:05 ` [PATCH 43/64] drivers: net: mlx4: " Allen Pais
2017-09-21 17:05 ` [PATCH 44/64] drivers: net: pxa168: " Allen Pais
2017-09-21 17:05 ` [PATCH 45/64] drivers: net: fealnx: " Allen Pais
2017-09-21 17:05 ` [PATCH 46/64] drivers: net: dmfe: " Allen Pais
2017-09-21 17:05 ` [PATCH 47/64] drivers: net: bnxt: " Allen Pais
2017-09-21 17:05 ` [PATCH 48/64] drivers: net: amd: " Allen Pais
2017-09-21 17:05 ` [PATCH 49/64] drivers: net: adi: " Allen Pais
2017-09-21 17:05 ` [PATCH 50/64] drivers: net: can: sja1000: " Allen Pais
2017-09-21 17:05 ` [PATCH 51/64] drivers: net: caif: " Allen Pais
2017-09-21 17:05 ` [PATCH 52/64] drivers: net: appletalk: " Allen Pais
2017-09-21 17:05 ` [PATCH 53/64] drivers: net: dscc: " Allen Pais
2017-09-21 17:05 ` Allen Pais [this message]
2017-09-21 17:05 ` [PATCH 55/64] drivers: net: hamradio: " Allen Pais
2017-09-21 17:05 ` [PATCH 56/64] drivers: net: cpsw_ale: " Allen Pais
2017-09-21 17:05 ` [PATCH 57/64] drivers: net: stmmac: " Allen Pais
2017-09-21 17:05 ` [PATCH 58/64] drivers: net: packetengines: " Allen Pais
2017-09-21 17:05 ` [PATCH 59/64] drivers: net: i40evf: " Allen Pais
2017-09-21 17:05 ` [PATCH 60/64] drivers: net: uli526x: " Allen Pais
2017-09-21 17:05 ` [PATCH 61/64] drivers: net: enic: " Allen Pais
2017-09-21 17:05 ` [PATCH 62/64] drivers: net: cxgb: " Allen Pais
2017-09-21 17:05 ` [PATCH 63/64] drivers: net: bnx2x: " Allen Pais
2017-09-21 17:05 ` [PATCH 64/64] drivers: net: lmc: " Allen Pais
2017-09-21 18:39 ` [PATCH 00/64] use setup_timer() helper function David Miller
2017-09-22 6:22 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506013525-29291-55-git-send-email-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=ajk@comnets.uni-bremen.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=f.fainelli@gmail.com \
--cc=jes@trained-monkey.org \
--cc=khc@pm.waw.pl \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.grzeschik@pengutronix.de \
--cc=mark.einon@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@frontier.com \
--cc=romieu@fr.zoreil.com \
--cc=simon@thekelleys.org.uk \
--cc=venza@brownhat.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).