From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH net-next 4/6] net: dsa: mv88e6xxx: Print offending port when vlan check fails
Date: Wed, 27 Sep 2017 00:26:01 +0200 [thread overview]
Message-ID: <1506464764-12699-5-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1506464764-12699-1-git-send-email-andrew@lunn.ch>
When testing if a VLAN is one more than one bridge, we print an error
message that the VLAN is already in use somewhere else. Print both the
new port which would like the VLAN, and the port which already has it,
to aid debugging.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 884f0507cf48..8a4756490a5a 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1134,8 +1134,8 @@ static int mv88e6xxx_port_check_hw_vlan(struct dsa_switch *ds, int port,
if (!ds->ports[i].bridge_dev)
continue;
- dev_err(ds->dev, "p%d: hw VLAN %d already used by %s\n",
- port, vlan.vid,
+ dev_err(ds->dev, "p%d: hw VLAN %d already used by port %d in %s\n",
+ port, vlan.vid, i,
netdev_name(ds->ports[i].bridge_dev));
err = -EOPNOTSUPP;
goto unlock;
--
2.14.1
next prev parent reply other threads:[~2017-09-26 22:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 22:25 [PATCH net-next 0/6] mv88e6xxx broadcast flooding in hardware Andrew Lunn
2017-09-26 22:25 ` [PATCH net-next 1/6] net: dsa: Fix SWITCHDEV_ATTR_ID_PORT_PARENT_ID Andrew Lunn
2017-09-27 10:15 ` Sergei Shtylyov
2017-09-27 15:31 ` Vivien Didelot
2017-09-26 22:25 ` [PATCH net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets Andrew Lunn
2017-09-27 19:46 ` Florian Fainelli
2017-09-27 20:11 ` Andrew Lunn
2017-09-26 22:26 ` [PATCH net-next 3/6] net: dsa: mv88e6xxx: Fixed port netdev check for VLANs Andrew Lunn
2017-09-26 22:26 ` Andrew Lunn [this message]
2017-09-27 15:49 ` [PATCH net-next 4/6] net: dsa: mv88e6xxx: Print offending port when vlan check fails Vivien Didelot
2017-09-26 22:26 ` [PATCH net-next 5/6] net: dsa: mv88e6xxx: Move mv88e6xxx_port_db_load_purge() Andrew Lunn
2017-09-27 15:51 ` Vivien Didelot
2017-09-26 22:26 ` [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware Andrew Lunn
2017-09-27 18:24 ` Vivien Didelot
2017-09-27 18:36 ` Andrew Lunn
2017-09-27 18:59 ` Vivien Didelot
2017-09-27 18:37 ` Florian Fainelli
2017-09-27 18:46 ` Andrew Lunn
2017-09-27 19:19 ` Vivien Didelot
2017-09-27 19:33 ` Florian Fainelli
2017-09-27 20:18 ` Andrew Lunn
2017-09-26 22:26 ` [PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports Andrew Lunn
2017-09-26 22:43 ` Andrew Lunn
2017-09-27 3:20 ` David Miller
2017-09-27 18:28 ` [PATCH net-next 0/6] mv88e6xxx broadcast flooding in hardware Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506464764-12699-5-git-send-email-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).